From: Richard Henderson <richard.henderson@linaro.org>
To: Karim Taha <kariem.taha2.7@gmail.com>, qemu-devel@nongnu.org
Cc: imp@bsdimp.com, Stacey Son <sson@FreeBSD.org>
Subject: Re: [PATCH 08/32] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion.
Date: Tue, 29 Aug 2023 12:36:28 -0700 [thread overview]
Message-ID: <cffcc325-f898-dcdb-477e-2d82447f9e8c@linaro.org> (raw)
In-Reply-To: <20230827155746.84781-9-kariem.taha2.7@gmail.com>
On 8/27/23 08:57, Karim Taha wrote:
> From: Stacey Son<sson@FreeBSD.org>
>
> Signed-off-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Karim Taha<kariem.taha2.7@gmail.com>
> ---
> bsd-user/bsd-proc.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> +rlim_t target_to_host_rlim(abi_llong target_rlim)
> +{
> + abi_llong target_rlim_swap;
> + rlim_t result;
> +
> + target_rlim_swap = tswap64(target_rlim);
> + if (target_rlim_swap == TARGET_RLIM_INFINITY) {
> + return RLIM_INFINITY;
> + }
> +
> + result = target_rlim_swap;
> + if (target_rlim_swap != (rlim_t)result) {
> + return RLIM_INFINITY;
> + }
> +
> + return result;
> +}
> +
> +abi_llong host_to_target_rlim(rlim_t rlim)
> +{
> + abi_llong target_rlim_swap;
> + abi_llong result;
> +
> + if (rlim == RLIM_INFINITY || rlim != (abi_llong)rlim) {
> + target_rlim_swap = TARGET_RLIM_INFINITY;
> + } else {
> + target_rlim_swap = rlim;
> + }
> + result = tswap64(target_rlim_swap);
> +
> + return result;
> +}
Though I think these are the identity function as well, since afaict we're always talking
about 64-bit data.
r~
next prev parent reply other threads:[~2023-08-29 23:18 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 15:57 [PATCH 00/32] bsd-user: Implement freebsd process related system calls Karim Taha
2023-08-27 15:57 ` [PATCH 01/32] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics Karim Taha
2023-08-29 19:07 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 02/32] bsd-user: Implement procctl(2) system call Karim Taha
2023-08-29 19:10 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 03/32] bsd-user: Implement host_to_target_siginfo Karim Taha
2023-08-29 19:13 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 04/32] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h Karim Taha
2023-08-29 19:14 ` Richard Henderson
2023-09-11 20:58 ` Karim Taha
2023-08-27 15:57 ` [PATCH 05/32] bsd-user: add extern declarations for bsd-proc.c conversion functions Karim Taha
2023-08-29 19:15 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 06/32] bsd-user: Add bsd-proc.c to meson.build Karim Taha
2023-08-29 19:17 ` Richard Henderson
2023-09-11 22:45 ` Karim Taha
2023-08-27 15:57 ` [PATCH 07/32] bsd-user: Implement target_to_host_resource conversion function Karim Taha
2023-08-29 19:33 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 08/32] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion Karim Taha
2023-08-29 19:36 ` Richard Henderson [this message]
2023-08-27 15:57 ` [PATCH 09/32] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage Karim Taha
2023-08-29 19:39 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 10/32] bsd-user: Implement host_to_target_waitstatus conversion Karim Taha
2023-08-29 19:40 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 11/32] bsd-user: Get number of cpus Karim Taha
2023-08-29 19:49 ` Richard Henderson
2023-08-29 21:03 ` Warner Losh
2023-08-27 15:57 ` [PATCH 12/32] bsd-user: Implement getgroups(2) and setgroups(2) system calls Karim Taha
2023-08-29 19:53 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 13/32] bsd-user: Implement umask(2), setlogin(2) and getlogin(2) Karim Taha
2023-08-29 19:56 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 14/32] bsd-user: Implement getrusage(2) Karim Taha
2023-08-29 19:57 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 15/32] bsd-user: Implement getrlimit(2) and setrlimit(2) Karim Taha
2023-08-29 19:58 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 16/32] bsd-user: Implement several get/set system calls: Karim Taha
2023-08-29 19:58 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 17/32] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid Karim Taha
2023-08-29 19:59 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 18/32] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2) Karim Taha
2023-08-29 20:00 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 19/32] bsd-user: Implement getpriority(2) and setpriority(2) Karim Taha
2023-08-29 20:10 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 20/32] bsd-user: Add freebsd/os-proc.c to meson.build Karim Taha
2023-08-29 20:12 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 21/32] bsd-user: Implement get_filename_from_fd Karim Taha
2023-08-29 20:17 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 22/32] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve Karim Taha
2023-08-29 20:28 ` Richard Henderson
2023-08-29 21:34 ` Warner Losh
2023-08-27 15:57 ` [PATCH 23/32] bsd-user: Implement t2h procctl control request commands and h2t reaper status struct conversion Karim Taha
2023-08-29 20:29 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 24/32] bsd-user: Implement h2t reaper_pidinfo and h2t/t2h reaper_kill structs conversion functions Karim Taha
2023-08-29 20:29 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 25/32] bsd-user: Implement procctl(2) system call Karim Taha
2023-08-29 20:30 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 26/32] bsd-user: Implement execve(2) and fexecve(2) system calls Karim Taha
2023-08-29 20:31 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 27/32] bsd-user: Implement wait4(2) and wait6(2) " Karim Taha
2023-08-29 20:33 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 28/32] bsd-user: Implement setloginclass(2) and getloginclass(2) " Karim Taha
2023-08-29 20:33 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 29/32] bsd-user: Implement pdgetpid(2) and the undocumented setugid Karim Taha
2023-08-29 20:36 ` Richard Henderson
2023-08-29 21:14 ` Warner Losh
2023-08-27 15:57 ` [PATCH 30/32] bsd-user: Implement fork(2) and vfork(2) system calls Karim Taha
2023-08-29 20:39 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 31/32] bsd-user: Implement rfork(2) system call Karim Taha
2023-08-29 20:43 ` Richard Henderson
2023-08-27 15:57 ` [PATCH 32/32] bsd-user: Implement pdfork(2) " Karim Taha
2023-08-29 20:58 ` Richard Henderson
2023-08-29 21:27 ` Warner Losh
2023-08-29 21:53 ` Richard Henderson
2023-08-29 22:06 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cffcc325-f898-dcdb-477e-2d82447f9e8c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=imp@bsdimp.com \
--cc=kariem.taha2.7@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).