From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Maefk-0004l9-LI for qemu-devel@nongnu.org; Mon, 10 Aug 2009 19:53:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Maeff-0004j7-Qr for qemu-devel@nongnu.org; Mon, 10 Aug 2009 19:53:00 -0400 Received: from [199.232.76.173] (port=51035 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Maeff-0004j2-Cx for qemu-devel@nongnu.org; Mon, 10 Aug 2009 19:52:55 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41820) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Maefe-0006mw-4G for qemu-devel@nongnu.org; Mon, 10 Aug 2009 19:52:55 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7ANqraJ020192 for ; Mon, 10 Aug 2009 19:52:53 -0400 From: Juan Quintela Date: Tue, 11 Aug 2009 01:50:42 +0200 Message-Id: Subject: [Qemu-devel] [PATCH v2 0/3] Make pcspk like rest of audio cards List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org v2 We use c99 initializers in malc style, open and closed parents in the same line, and = signs aligned. v1: This patch series add c99 initializers to sound cards in vl.c. Sound card support depends of target, move CONFIG_FOO generation there. Once here, I wanted to disable CONFIG_PCSPK, but found a problem. pcskpr is registered as a port on mips_jazz.c and pc.c, and then as an audio card. Options are: - let things as they are (if you get a pc or mips_jazz, you get a pc speaker port and a pcspk audio card. - be able to remove pc speaker audio support, but let the speaker port as it is now - make pcspk_init() an empty function in hw.h depending of CONFIG_PCSPK value. Any thoughts? Later, Juan. Juan Quintela (3): Bring audio cards structs to C99 initializers What cards to compile is a per target thing Make pc speaker be configured the same way that the rest of the cards Makefile.target | 5 ++- configure | 16 +++++++-- vl.c | 91 +++++++++++++++++++++++-------------------------------- 3 files changed, 53 insertions(+), 59 deletions(-)