qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 0/2] SaveVM: Remove ram support for v1 and v2
Date: Wed,  9 Sep 2009 12:47:39 +0200	[thread overview]
Message-ID: <cover.1252493145.git.quintela@redhat.com> (raw)

Hi

SaveVM don't work for v2 since at least April.

>From commit message of removal of v2:

It don't work.  It fails in this check

        if (qemu_get_be32(f) != last_ram_offset)

With 512MB of ram, values were for me:

	v = 20c00000 last_ram_offset = 20840000

Last time that some code changed that was this one.

    commit 94a6b54fd6d2d3321066cb4db7abeeb417af9365
    Implement dynamic guest ram allocation.
    (I.e. it has been broken since at least April)

Going back to the previous commit, ram load correctly, but vga screen gets
corrupted and ide don't load correctly.  At this point I decide that removing
support is the only viable thing.

The last user of the ram_compress_* were RAM_SAVE_FLAG_FULL flag, but
that flag was never ever been stored in an image. Mark the flag obsolete
and remove the functions.


Later, Juan.

Juan Quintela (2):
  ram: remove support for loading v1
  ram: Remove SaveVM Version 2 support

 vl.c |  136 +-----------------------------------------------------------------
 1 files changed, 1 insertions(+), 135 deletions(-)

             reply	other threads:[~2009-09-09 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09 10:47 Juan Quintela [this message]
2009-09-09 10:47 ` [Qemu-devel] [PATCH 1/2] ram: remove support for loading v1 Juan Quintela
2009-09-09 10:47 ` [Qemu-devel] [PATCH 2/2] ram: Remove SaveVM Version 2 support Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1252493145.git.quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).