From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlKiP-0002AX-ID for qemu-devel@nongnu.org; Wed, 09 Sep 2009 06:47:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlKiI-00021d-Di for qemu-devel@nongnu.org; Wed, 09 Sep 2009 06:47:50 -0400 Received: from [199.232.76.173] (port=35099 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlKiH-00021T-OA for qemu-devel@nongnu.org; Wed, 09 Sep 2009 06:47:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25380) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlKiH-0004nq-93 for qemu-devel@nongnu.org; Wed, 09 Sep 2009 06:47:45 -0400 From: Juan Quintela Date: Wed, 9 Sep 2009 12:47:39 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 0/2] SaveVM: Remove ram support for v1 and v2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Hi SaveVM don't work for v2 since at least April. >>From commit message of removal of v2: It don't work. It fails in this check if (qemu_get_be32(f) != last_ram_offset) With 512MB of ram, values were for me: v = 20c00000 last_ram_offset = 20840000 Last time that some code changed that was this one. commit 94a6b54fd6d2d3321066cb4db7abeeb417af9365 Implement dynamic guest ram allocation. (I.e. it has been broken since at least April) Going back to the previous commit, ram load correctly, but vga screen gets corrupted and ide don't load correctly. At this point I decide that removing support is the only viable thing. The last user of the ram_compress_* were RAM_SAVE_FLAG_FULL flag, but that flag was never ever been stored in an image. Mark the flag obsolete and remove the functions. Later, Juan. Juan Quintela (2): ram: remove support for loading v1 ram: Remove SaveVM Version 2 support vl.c | 136 +----------------------------------------------------------------- 1 files changed, 1 insertions(+), 135 deletions(-)