From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm38D-0004NO-7w for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:13:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm386-0004M3-T5 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:13:28 -0400 Received: from [199.232.76.173] (port=36099 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm386-0004Lw-7Y for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:13:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19759) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mm385-0000rl-Hu for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:13:21 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BADKe1030364 for ; Fri, 11 Sep 2009 06:13:20 -0400 From: Juan Quintela Date: Fri, 11 Sep 2009 12:10:20 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 00/20] VMState: port all i2c devices List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi This patch is on top of my previous series: [PATCH 00/26] VMState: port several pc devices to vmstate This ports all i2c_devices to vmstate. Big changes: - i2c->address now are uint8_t, my review of all uses is that they are always used as uint8_t (and that is the type that is passed on the value). If you know i2c, please check. Change 0002 looks big, but it is because as I was auditing the paths, I changed the types of the functios to reflect that they use uint8_t. Real part of the patch is changing the struct definitions. - qdev: there was not support for uint8_t (the i2c addresses) in qdev, now it is I missed this change in my 1st pass (on mips_malta) - qdev_prop_set_uint32(eeprom, "address", 0x50 + i); + qdev_prop_set_uint8(eeprom, "address", 0x50 + i); And qdev complained during compilation. qdev++ - I had to fix lots of places where values of one type were sent with a different type. qemu_put_byte/qemu_put_be16/qemu_put_be32 should be just baned. Yesterday. - tmp105: We have a winner, the 1st user of post_save(). Can anyone explain me what we need to do _anything_ after saving s->faults = tmp105_faultq[(s->config >> 3) & 3]; /* F */ I can't see why saving have to change faults, and no, I don't understand what that line does. - twl922230: here we go. It pass all the fields of a struct tm (they are ints) as uint16_t. All solutions are bad (tm): * marshalling the struct tm in a struct tm_16bits fields, and use normal vmstate * up version and declare all previous versions baned. No forward migration for you. * Do the hack that I did, new type: vmstate_hack_int32_as_uint16 local to that function, and be done with it. It is a big hack, but the function were already abusing the format. - lm832x: I got an unused command (0xff) to be send as an error. it was using an int, -1 means an error, and a small number meaned a command. As the numbers of commands is very limited, I think this is the best solution. Notice that we were doing this already when we saved/loaded the value. Name the constant instead of -1 to make things easier. - vmstate arrays shortened the save/load code for this series _a lot_. Comments? Test and reports from arm users are welcome (the only use of i2c in a pc is for smbus-eeprom, and it is a _very_ limited use). Later, Juan. Juan Quintela (20): qdev: Add support for uint8_t i2c: addresses are load/save as uint8_t values, change types to reflect this vmstate: port i2c_bus device vmstate: port i2c_slave device vmstate: add uint8 array vmstate: create VMSTATE_I2C_SLAVE vmstate: port wm8750 device vmstate: port max7310 device vmstate: create VMSTATE_STRUCT_POINTER vmstate: port pxa2xx_i2c device vmstate: port ssd0303 device vmstate: create VMSTATE_INT16_ARRAY tmp105: change len and alorm to uint8_t vmstate: port wmp105 device twl92230: change pwrbtn_state to uint8_t vmstate: port twl92230 device vmstate: add support for arrays of pointers lm832x: make fields to have the same types that they are saved/loaded vmstate: port lm832x device vmstate: remove i2c_slave_load/save hw/hw.h | 47 ++++++++++++ hw/i2c.c | 64 ++++++++++------ hw/i2c.h | 10 +-- hw/lm832x.c | 148 +++++++++++++++---------------------- hw/max7310.c | 51 +++++-------- hw/mips_malta.c | 2 +- hw/pc.c | 2 +- hw/pxa2xx.c | 54 +++++++------- hw/qdev-properties.c | 33 ++++++++ hw/qdev.h | 5 + hw/smbus.c | 18 ++-- hw/smbus.h | 18 ++-- hw/ssd0303.c | 65 ++++++----------- hw/tmp105.c | 60 +++++++-------- hw/twl92230.c | 200 ++++++++++++++++++++++---------------------------- hw/wm8750.c | 120 +++++++++++------------------- savevm.c | 3 + 17 files changed, 438 insertions(+), 462 deletions(-)