From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqEdj-0008Fb-4l for qemu-devel@nongnu.org; Tue, 22 Sep 2009 19:19:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqEdc-0008BG-1z for qemu-devel@nongnu.org; Tue, 22 Sep 2009 19:19:16 -0400 Received: from [199.232.76.173] (port=54122 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqEdb-0008BA-Rh for qemu-devel@nongnu.org; Tue, 22 Sep 2009 19:19:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62043) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqEdZ-0003Tk-0q for qemu-devel@nongnu.org; Tue, 22 Sep 2009 19:19:10 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8MNJ7ZE013878 for ; Tue, 22 Sep 2009 19:19:07 -0400 From: Juan Quintela Date: Wed, 23 Sep 2009 01:18:58 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi In commemoration of the 20th anniversary of the c89 standard, this brings qemu codebase to c89. How do I know? Previous to last patch adds to QEMU_CFLAGS: -Wold-style-declaration -Wold-style-definition Why? - typedef abuse for the 1st patch. How that ever worked, I don't know. - gcc gets picky, and you have to declare functions as: static inline void f(...) inline static void f(...) but static void inline f(...) gets warnings. Just move the few functions that have the third format to the 1st one. - bring alpha-dis.c and sh4-dis.c to ansi c89 function declaration. - static + const: gcc wants you to use: static const and gives a warning for const static - same for static + __thread (only 1 occurrence) - last patch removes PARAMS() from dis-asm.h last users were alpha-dis.c and sh4-dis.c (do you start to see a pattern here). Last one is not required, but as qemu is not going to compile in pre-c89 compiler any time soon, it is better to also apply it. Later, Juan. Juan Quintela (7): Use proper typedef syntax static and inline should came before the type of the functions Bring two last users of K&R definitions to ANSI c89 gcc wants 1st static and then const __thread should be before real type Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS Remove PARAMS() macro alpha-dis.c | 116 ++++++++++++------------------------- configure | 1 + dis-asm.h | 102 ++++++++++++++++----------------- gen-icount.h | 2 +- hw/g364fb.c | 4 +- hw/pflash_cfi01.c | 2 +- hw/serial.c | 4 +- hw/sh7750.c | 2 +- hw/usb-bt.c | 2 +- hw/xen_blkif.h | 4 +- linux-user/arm/nwfpe/fpa11_cprt.c | 2 +- linux-user/mmap.c | 2 +- sh4-dis.c | 32 +++------- target-i386/kvm.c | 2 +- target-microblaze/translate.c | 4 +- target-ppc/translate.c | 8 +- 16 files changed, 116 insertions(+), 173 deletions(-)