From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvJGQ-0003O7-OP for qemu-devel@nongnu.org; Tue, 06 Oct 2009 19:16:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvJGK-0003LG-JN for qemu-devel@nongnu.org; Tue, 06 Oct 2009 19:16:13 -0400 Received: from [199.232.76.173] (port=52560 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvJGK-0003Kx-8j for qemu-devel@nongnu.org; Tue, 06 Oct 2009 19:16:08 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]:50055) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MvJGJ-0005II-JF for qemu-devel@nongnu.org; Tue, 06 Oct 2009 19:16:07 -0400 Received: from pike.pond.sub.org (pD9E3BD77.dip.t-dialin.net [217.227.189.119]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 71996276C73 for ; Wed, 7 Oct 2009 01:16:06 +0200 (CEST) From: Markus Armbruster Date: Wed, 7 Oct 2009 01:15:54 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 0/7] Clean up use of qdev_init() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org qdev_init() can fail since commit 81a322d4. Most callers don't bother to check. This is less serious than it sounds, because they typically work with devices for which qdev_init() never fails. It's still unclean. The second to last patch makes the compiler warn when the value of qdev_init() isn't used. If that warning triggers after merging this series, more unchecked calls have crept in since the base of this series (commit 2637c754). Feel free to ask me for a respin then. Changes since v1: * Drop cleanup of xilinx.h * Fix a bug that crept into usb-linux since v1 * Cover new uses of qdev_init() * Clean up test for qdev_init() failure Markus Armbruster (7): Unbreak USB autoconnect filters Make qdev_init() destroy the device on failure Check return value of qdev_init() New qdev_init_nofail() Make isa_create() terminate program on failure Warn if value of qdev_init() isn't checked Clean up test for qdev_init() failure hw/apb_pci.c | 2 +- hw/arm_sysctl.c | 2 +- hw/armv7m.c | 6 +++--- hw/axis_dev88.c | 2 +- hw/escc.c | 4 ++-- hw/esp.c | 2 +- hw/etraxfs.c | 2 +- hw/fdc.c | 8 +++----- hw/grackle_pci.c | 2 +- hw/i2c.c | 2 +- hw/ide/isa.c | 2 +- hw/ide/pci.c | 2 +- hw/ide/qdev.c | 2 +- hw/integratorcp.c | 2 +- hw/isa-bus.c | 11 ++++------- hw/m48t59.c | 4 ++-- hw/mc146818rtc.c | 2 +- hw/mips_malta.c | 2 +- hw/musicpal.c | 4 ++-- hw/ne2000-isa.c | 2 +- hw/parallel.c | 2 +- hw/pc.c | 2 +- hw/pci-hotplug.c | 4 ++-- hw/pci.c | 5 +++-- hw/piix_pci.c | 2 +- hw/qdev.c | 26 ++++++++++++++++++++++---- hw/qdev.h | 3 ++- hw/scsi-bus.c | 4 +++- hw/serial.c | 2 +- hw/smc91c111.c | 2 +- hw/ssi.c | 2 +- hw/stellaris.c | 2 +- hw/sun4m.c | 28 ++++++++++++++-------------- hw/sun4u.c | 4 ++-- hw/syborg.c | 4 ++-- hw/sysbus.c | 2 +- hw/unin_pci.c | 2 +- hw/usb-bus.c | 2 +- hw/usb-msd.c | 3 ++- hw/vga-pci.c | 2 +- hw/xilinx.h | 6 +++--- usb-linux.c | 8 ++++---- 42 files changed, 100 insertions(+), 82 deletions(-)