qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Glauber Costa <glommer@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 00/21] qemu-kvm: Hook cleanups and extended use of upstream code
Date: Tue,  2 Feb 2010 09:18:46 +0100	[thread overview]
Message-ID: <cover.1265098706.git.jan.kiszka@siemens.com> (raw)

Let's start with the overall stats:

 31 files changed, 274 insertions(+), 822 deletions(-)

So this series drops far more than 500 lines of redundant code, moving
qemu-kvm yet a bit closer to upstream.

The other highlight is the simplification of synchronization between
in-kernel and user space VCPU states. This area used to call a lot of
problems in the past because it was tricky to get things right,
specifically during the multi-threaded startup. The new approach pushes
all the sync work around reset and vmsave/load into generic code, not
only removing the burden from developers of, say, in-kernel APIC
support, but also dropping most of our kvm-specific hooks, especially in
the qemu-kvm tree.

While I tested this on various VMs around, and things look good so far,
I wouldn't be surprised if there are some regressions remaining,
specifically in the non-x86 parts that I wasn't able to test or even
build. Please have a careful look!

Regarding the organization of the series: Patches prefixed with "KVM:"
are for upstream, unmodified or with only minor adjustments. But I have
a separate series against uq/master here that just needs final polishing
and can then be rolled out as well.

You can pull this series from

	git://git.kiszka.org/qemu-kvm.git queues/vcpu-state

There are two more items on my to-do list, yet with medium prio:
 o switch kvm_arch_save/load_regs and sub-functions to upstream code
 o drop qemu-kvm's slot management in favor of upstream's implementation

Jan Kiszka (21):
  qemu-kvm: Drop vmport changes
  KVM: Make vmport KVM-compatible
  qemu-kvm: Clean up register access API
  KVM: x86: Fix up misreported CPU features
  qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state
  qemu-kvm: Use upstream kvm_setup_guest_memory
  qemu-kvm: Use some more upstream prototypes
  qemu-kvm: Use upstream kvm_arch_get_supported_cpuid
  qemu-kvm: Use upstream kvm_pit_in_kernel
  KVM: Move and rename regs_modified
  KVM: Rework of guest debug state writing
  qemu-kvm: Use upstream kvm_vcpu_dirty
  qemu-kvm: Use upstream guest debug code
  qemu-kvm: Rework VCPU state writeback API
  qemu-kvm: Clean up mpstate synchronization
  KVM: x86: Restrict writeback of VCPU state
  qemu-kvm: Use VCPU event state for reset and vmsave/load
  qemu-kvm: Cleanup/fix TSC and PV clock writeback
  qemu-kvm: Clean up KVM's APIC hooks
  qemu-kvm: Move kvm_set_boot_cpu_id
  qemu-kvm: Bring qemu_init_vcpu back home

 cpu-defs.h            |    2 +-
 exec.c                |   17 --
 hw/apic.c             |   47 +-----
 hw/i8254.c            |    6 +-
 hw/i8259.c            |    2 +-
 hw/ioapic.c           |    2 +-
 hw/msix.c             |    3 +-
 hw/pc.c               |   13 +--
 hw/pcspk.c            |    4 +-
 hw/piix_pci.c         |    2 +-
 hw/ppc_newworld.c     |    3 -
 hw/ppc_oldworld.c     |    3 -
 hw/s390-virtio.c      |    1 -
 hw/vmport.c           |   14 +--
 kvm-all.c             |   51 +++---
 kvm.h                 |   35 +++--
 qemu-kvm-ia64.c       |    6 +-
 qemu-kvm-x86.c        |  415 +++++++++----------------------------------------
 qemu-kvm.c            |  159 +++----------------
 qemu-kvm.h            |  158 +------------------
 savevm.c              |    4 +
 sysemu.h              |    4 +
 target-i386/cpu.h     |    9 +-
 target-i386/helper.c  |    2 +
 target-i386/kvm.c     |   61 +++++--
 target-i386/machine.c |   27 ----
 target-ia64/machine.c |    5 +-
 target-ppc/kvm.c      |    2 +-
 target-ppc/machine.c  |    4 -
 target-s390x/kvm.c    |    3 +-
 vl.c                  |   32 ++++-
 31 files changed, 274 insertions(+), 822 deletions(-)

             reply	other threads:[~2010-02-02  9:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02  8:18 Jan Kiszka [this message]
2010-02-02  8:18 ` [Qemu-devel] [PATCH 01/21] qemu-kvm: Drop vmport changes Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 02/21] KVM: Make vmport KVM-compatible Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 03/21] qemu-kvm: Clean up register access API Jan Kiszka
2010-02-02 11:06   ` [Qemu-devel] " Gleb Natapov
2010-02-02 11:18     ` Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 04/21] KVM: x86: Fix up misreported CPU features Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 05/21] qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 06/21] qemu-kvm: Use upstream kvm_setup_guest_memory Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 07/21] qemu-kvm: Use some more upstream prototypes Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 08/21] qemu-kvm: Use upstream kvm_arch_get_supported_cpuid Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 09/21] qemu-kvm: Use upstream kvm_pit_in_kernel Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 10/21] KVM: Move and rename regs_modified Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 11/21] KVM: Rework of guest debug state writing Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 12/21] qemu-kvm: Use upstream kvm_vcpu_dirty Jan Kiszka
2010-02-02  8:18 ` [Qemu-devel] [PATCH 13/21] qemu-kvm: Use upstream guest debug code Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 14/21] qemu-kvm: Rework VCPU state writeback API Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 15/21] qemu-kvm: Clean up mpstate synchronization Jan Kiszka
2010-02-02 12:23   ` [Qemu-devel] " Gleb Natapov
2010-02-02 12:31     ` Jan Kiszka
2010-02-02 12:37       ` Gleb Natapov
2010-02-02 12:40         ` Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 16/21] KVM: x86: Restrict writeback of VCPU state Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 17/21] qemu-kvm: Use VCPU event state for reset and vmsave/load Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 18/21] qemu-kvm: Cleanup/fix TSC and PV clock writeback Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 19/21] qemu-kvm: Clean up KVM's APIC hooks Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 20/21] qemu-kvm: Move kvm_set_boot_cpu_id Jan Kiszka
2010-02-02 14:11   ` [Qemu-devel] " Gleb Natapov
2010-02-02 14:20     ` Jan Kiszka
2010-02-02 14:28       ` Gleb Natapov
2010-02-02 14:33         ` Jan Kiszka
2010-02-02  8:19 ` [Qemu-devel] [PATCH 21/21] qemu-kvm: Bring qemu_init_vcpu back home Jan Kiszka
2010-02-02 10:52 ` [Qemu-devel] Re: [PATCH 00/21] qemu-kvm: Hook cleanups and extended use of upstream code Alexander Graf
2010-02-02 11:19   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1265098706.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).