From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmnM2-0000ja-7Y for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:06 -0500 Received: from [199.232.76.173] (port=53668 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmnM1-0000jG-NE for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:05 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NmnM0-0005Hk-Bo for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56277) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NmnLz-0005Hg-WF for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:04 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o23C73RT013811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Mar 2010 07:07:03 -0500 From: Juan Quintela Date: Wed, 3 Mar 2010 13:06:50 +0100 Message-Id: Subject: [Qemu-devel] [PATCH 00/10] FORTIFY_SOURCE followup List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, amit.shah@redhat.com Hi This series make: - all block *_create() functions return -errno instead of -1 - this makes that we can end writting errno/error at bdrv_create() callers (qemu-img) - once there found a double free problem in the error handling of vmdk, fixed it. - slirp: also check that system() was able to fork (amit noticed it) - daemonize: if we are unable to write into the pipe, print a message and exit. We can't really recover from that error (amit noticed it). Please review and apply. Later, Juan. Juan Quintela (10): cow: return errno instead of -1 slirp: check system() success qcow2: return errno instead of -1 qcow: return errno instead of -1 vmdk: return errno instead of -1 vl: exit if we are not able to write into the pipe vmdk: make vmdk_snapshot_create return -errno vmdk: fix double free vmdk: share cleanup code block: print errno on error block/cow.c | 5 +-- block/qcow.c | 8 ++-- block/qcow2.c | 18 +++++----- block/vmdk.c | 106 +++++++++++++++++++++++++++++++++++++-------------------- net/slirp.c | 2 +- qemu-img.c | 4 +- vl.c | 1 + 7 files changed, 88 insertions(+), 56 deletions(-)