qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Cc: Michael Walle <michael@walle.cc>
Subject: [Qemu-devel] [PATCH 0/4] Fix the lazy CFI mode switch
Date: Thu, 13 May 2010 16:16:44 +0200	[thread overview]
Message-ID: <cover.1273760202.git.jan.kiszka@web.de> (raw)

This series addresses the major problem lazy mode switching of the
pflash_cfi02 currently has: code execution from this ROM can fail.

The reason for this was a conceptual issue that was papered over by a
bug in the original implementation. Both are addressed here by
 - allowing code execution from marked I/O memory regions (specifically
   ROM devices)
 - performing the lazy switch back of cfi02 from reprogramming to ROM
   mode via a timer

To recall why this effort is needed: Programming 7 MB of an 8 MB flash
that does not support the unlock bypass command takes 5:40 minutes with
this optimization and about 3 h (estimated, it became boring to wait for
completion) without it.

Jan Kiszka (4):
  cfi02: Fix a debug print
  Add support for execution from ROMs in IO device mode
  cfi: Mark flash memory executable
  cfi02: Use timer-based ROM mode switch

 cpu-common.h      |    2 ++
 exec-all.h        |    2 +-
 exec.c            |    2 +-
 hw/pflash_cfi01.c |    9 +++++----
 hw/pflash_cfi02.c |   46 ++++++++++++++++++++++++++++++++++------------
 5 files changed, 43 insertions(+), 18 deletions(-)

             reply	other threads:[~2010-05-13 14:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 14:16 Jan Kiszka [this message]
2010-05-13 14:16 ` [Qemu-devel] [PATCH 1/4] cfi02: Fix a debug print Jan Kiszka
2010-05-13 14:16 ` [Qemu-devel] [PATCH 2/4] Add support for execution from ROMs in IO device mode Jan Kiszka
2010-05-13 19:23   ` Jamie Lokier
2010-05-13 20:10     ` Jan Kiszka
2010-05-13 20:24       ` Jan Kiszka
2010-05-13 14:16 ` [Qemu-devel] [PATCH 3/4] cfi: Mark flash memory executable Jan Kiszka
2010-05-13 14:16 ` [Qemu-devel] [PATCH 4/4] cfi02: Use timer-based ROM mode switch Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1273760202.git.jan.kiszka@web.de \
    --to=jan.kiszka@web.de \
    --cc=michael@walle.cc \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).