qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/5] Add QMP migration events
Date: Tue, 25 May 2010 16:21:00 +0200	[thread overview]
Message-ID: <cover.1274796992.git.quintela@redhat.com> (raw)

v2:
- Address pbonzini and mst changes
  (error messages and doc fixes)

v1:

This series does:

- exit incoming migration on failure.  For exec/fd migrations, once
  there was a failure, there was nothing useful to do.  And for tcp
  migration, not exiting created interesting bugs when trying to
  migrate again to a process with a faild migration.

- Factorize common migration code, no more duplication, makes easier to do
  "global" migration things, like QMP events.

- Introduce QMP events, both for incoming and outgoing migration.


Now, the million dollar question: Why I didn't refactorize outgoing
migration?  I tried, and have it partially done on my local tree.  But
it depends (too much) of current_migration global variable -> Libvirt
folks will also want "info migrate" to work on the incoming side,
i.e. current_migraition has to also be updated on incoming side.  Done
until here, but then I hit the wall "incoming migration is synchronous".

To make the monitor work on incoming migration, we need to change
buffered_file.c abstraction to also work for incoming fd's, or another
similar solution.  I am open to suggestions about what to do here.

This series are quite simple (the unfinished part is more complex),
will send the other part as an RFC later.

Please review and consider to apply it.

Later, Juan.


Juan Quintela (5):
  Exit if incoming migration fails
  Factorize common migration incoming code
  QMP: Introduce MIGRATION events
  QMP: Emit migration events on incoming migration
  QMP: Emit migration events on outgoing migration

 QMP/qmp-events.txt |   50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 migration-exec.c   |   17 +++--------------
 migration-fd.c     |   15 ++-------------
 migration-tcp.c    |   17 ++++-------------
 migration-unix.c   |   17 ++++-------------
 migration.c        |   37 +++++++++++++++++++++++++++++++------
 migration.h        |    4 +++-
 monitor.c          |   12 ++++++++++++
 monitor.h          |    4 ++++
 vl.c               |    7 ++++++-
 10 files changed, 119 insertions(+), 61 deletions(-)

             reply	other threads:[~2010-05-25 14:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25 14:21 Juan Quintela [this message]
2010-05-25 14:21 ` [Qemu-devel] [PATCH 1/5] Exit if incoming migration fails Juan Quintela
2010-05-25 18:01   ` Luiz Capitulino
2010-05-25 18:37     ` [Qemu-devel] " Juan Quintela
2010-05-25 18:52       ` Anthony Liguori
2010-05-25 14:21 ` [Qemu-devel] [PATCH 2/5] Factorize common migration incoming code Juan Quintela
2010-05-25 14:21 ` [Qemu-devel] [PATCH 3/5] QMP: Introduce MIGRATION events Juan Quintela
2010-05-25 15:09   ` Anthony Liguori
2010-05-25 15:35     ` [Qemu-devel] " Juan Quintela
2010-05-25 15:52       ` Daniel P. Berrange
2010-05-25 15:57       ` Anthony Liguori
2010-05-25 16:04         ` Juan Quintela
2010-05-25 16:10           ` Anthony Liguori
2010-05-25 18:13             ` Luiz Capitulino
2010-05-25 16:04         ` Daniel P. Berrange
2010-05-25 16:04         ` Juan Quintela
2010-05-25 16:25           ` Daniel P. Berrange
2010-05-25 16:33             ` Anthony Liguori
2010-05-25 16:43               ` Juan Quintela
2010-05-26 10:33                 ` Daniel P. Berrange
2010-05-26 14:54                   ` Anthony Liguori
2010-05-26 15:15                     ` Daniel P. Berrange
2010-05-26 16:55                       ` Anthony Liguori
2010-05-27 13:48                         ` Luiz Capitulino
2010-05-27 15:58                           ` Juan Quintela
2010-05-27 16:07                             ` Luiz Capitulino
2010-05-27 16:07                             ` Anthony Liguori
2010-05-26 10:16               ` Daniel P. Berrange
2010-05-25 18:21       ` Luiz Capitulino
2010-05-25 18:38         ` Juan Quintela
2010-05-25 15:48     ` [Qemu-devel] " Daniel P. Berrange
2010-05-25 18:31   ` Luiz Capitulino
2010-05-25 18:51     ` Anthony Liguori
2010-05-26 13:14       ` Luiz Capitulino
2010-05-25 14:21 ` [Qemu-devel] [PATCH 4/5] QMP: Emit migration events on incoming migration Juan Quintela
2010-05-25 14:21 ` [Qemu-devel] [PATCH 5/5] QMP: Emit migration events on outgoing migration Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1274796992.git.quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).