qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately
Date: Fri, 17 Dec 2010 15:58:52 +0100	[thread overview]
Message-ID: <cover.1292597932.git.jan.kiszka@siemens.com> (raw)

By default, we base the mc146818 RTC on the host clock (CLOCK_REALTIME).
This works fine if only the frequency of the host clock is tuned (e.g.
by NTP) or if it is set to a future time. However, if the host is tuned
backward, e.g. because NTP obtained the correct time after the guest was
already started or the admin decided to tune the local time, we see an
unpleasant effect in the guest: The RTC will stall for the period the
host clock is set back.

This series tries to address the issue more gracefully. By detecting
those warps and providing a callback mechanism to device models, the
RTC is enabled to update its timers and register content immediately.
Tested successfully with a hwclock readout loop in a Linux guest while
fiddling with the host time.

Note that if this kind of RTC adjustment is not wanted, the user is
still free to decouple the RTC from the host clock and base it on the
VM clock - just like before.

Jan Kiszka (3):
  qemu-timer: Consolidate qemu_get_clock and qemu_get_clock_ns
  qemu-timer: Introduce warp callback
  mc146818rtc: Handle host clock warps

 hw/mc146818rtc.c |   17 ++++++++++++
 qemu-timer.c     |   77 ++++++++++++++++++++++++++++++++++++++++++++----------
 qemu-timer.h     |    5 +++
 3 files changed, 85 insertions(+), 14 deletions(-)

             reply	other threads:[~2010-12-17 14:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17 14:58 Jan Kiszka [this message]
2010-12-17 14:58 ` [Qemu-devel] [RFC][PATCH 1/3] qemu-timer: Consolidate qemu_get_clock and qemu_get_clock_ns Jan Kiszka
2010-12-17 14:58 ` [Qemu-devel] [RFC][PATCH 2/3] qemu-timer: Introduce warp callback Jan Kiszka
2010-12-17 14:58 ` [Qemu-devel] [RFC][PATCH 3/3] mc146818rtc: Handle host clock warps Jan Kiszka
2010-12-23 20:45 ` [Qemu-devel] [RFC][PATCH 0/3] Let RTC follow backward jumps of host clock immediately Zachary Amsden
2011-01-12 11:26   ` Jan Kiszka
2011-01-12 12:27     ` Gleb Natapov
2011-01-12 13:05       ` Jan Kiszka
2011-01-12  9:04         ` Jan Kiszka
2011-01-26 11:46 ` [Qemu-devel] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1292597932.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).