qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Isaku Yamahata <yamahata@valinux.co.jp>
To: qemu-devel@nongnu.org
Cc: yamahata@valinux.co.jp, mst@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/3] piix_pci: optimize irq data path
Date: Sat, 19 Mar 2011 22:24:49 +0900	[thread overview]
Message-ID: <cover.1300540833.git.yamahata@valinux.co.jp> (raw)

This patch series optimizes irq data path of piix_pci.
So far piix3 tracks each pirq level and checks whether a given pic pins is
asserted by seeing if each pirq is mapped into the pic pin.
This is independent on irq routing, but data path is on slow path.

Given that irq routing is rarely changed and asserting pic pins is on
data path, the path that asserts pic pins should be optimized and
chainging irq routing should be on slow path.
The new behavior with this patch series is to use bitmap which is addressed
by pirq and pic pins with a given irq routing.
When pirq is asserted, the bitmap is set and see if the pic pins is
asserted by checking the bitmaps.
When irq routing is changed, rebuild the bitmap and re-assert pic pins.

Changes v2 -> v3:
- s/dummy_for_save_load_compat/pci_irq_levels_vmstate/g
- move down unused member of pci_irq_levels_vmstate in the structure
  for cache efficiency

Changes v1 -> v2:
- addressed review comments.



Isaku Yamahata (3):
  pci: add accessor function to get irq levels
  piix_pci: eliminate PIIX3State::pci_irq_levels
  piix_pci: optimize set irq path

 hw/pci.c      |    7 +++
 hw/pci.h      |    1 +
 hw/piix_pci.c |  119 +++++++++++++++++++++++++++++++++++++++++++++++---------
 3 files changed, 108 insertions(+), 19 deletions(-)

             reply	other threads:[~2011-03-19 13:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-19 13:24 Isaku Yamahata [this message]
2011-03-19 13:24 ` [Qemu-devel] [PATCH v3 1/3] pci: add accessor function to get irq levels Isaku Yamahata
2011-03-19 13:24 ` [Qemu-devel] [PATCH v3 2/3] piix_pci: eliminate PIIX3State::pci_irq_levels Isaku Yamahata
2011-03-19 13:24 ` [Qemu-devel] [PATCH v3 3/3] piix_pci: optimize set irq path Isaku Yamahata
2011-03-21 11:37   ` [Qemu-devel] " Michael S. Tsirkin
2011-03-21 12:10     ` Isaku Yamahata
2011-03-21 12:31       ` Michael S. Tsirkin
2011-03-21 12:56         ` Isaku Yamahata
2011-03-21 13:01           ` Michael S. Tsirkin
2011-03-21 12:26     ` Isaku Yamahata
2011-03-21 14:10   ` Michael S. Tsirkin
2011-03-22  0:50     ` Isaku Yamahata
2011-03-22 13:40       ` Michael S. Tsirkin
2011-03-22 14:07         ` Isaku Yamahata
2011-03-22 16:24           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1300540833.git.yamahata@valinux.co.jp \
    --to=yamahata@valinux.co.jp \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).