qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	Amit Shah <amit.shah@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/5] atapi: Implement 'media' subcommand for GESN
Date: Tue, 12 Apr 2011 17:13:19 +0530	[thread overview]
Message-ID: <cover.1302608369.git.amit.shah@redhat.com> (raw)

The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a
mandatory command in the spec but we don't really implement it any of
its sub-commands.

The commit message for the last commit explains why implementing just
the media subcommand is helpful and how it goes a long way in getting
guests to behave as expected.

The difference from the RFC series sent earlier is:
- Split into more patches
- Add tray open/close notification (from Markus)

There certainly is much more work to be done for the other commands
and also for state change handling (tray open / close / new media)
overall for the block layer, but this is a good first step in being
spec-compliant and at the same time making guests work.

v3:
 - Add gesn_event_header struct, further removing a few constants used
 - Set reserved bits to 0 for the media subcommand
 - Remove the function handling NEA, move to generic code
 - Re-do patch series to reflect above change
 - Merge vmstate patches with patch introducing new fields
 - Merge fixes for other comments by Kevin

v2:
 - Update comments
 - Use struct instead of enum for cdb packet
 - Add a new subsection to vmstate for new fields for save/restore

v1:
 - Split into more patches
 - Add tray open/close notification (from Markus)

RFC:
 - Orig. series

Amit Shah (5):
  atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change
  atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own
    function
  atapi: GESN: Use structs for commonly-used field types
  atapi: GESN: Standardise event response handling for future additions
  atapi: GESN: implement 'media' subcommand

 hw/ide/core.c     |  182 +++++++++++++++++++++++++++++++++++++++++++++++------
 hw/ide/internal.h |    6 ++
 2 files changed, 169 insertions(+), 19 deletions(-)

-- 
1.7.4.2

             reply	other threads:[~2011-04-12 11:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 11:43 Amit Shah [this message]
2011-04-12 11:43 ` [Qemu-devel] [PATCH v3 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change Amit Shah
2011-04-12 11:43 ` [Qemu-devel] [PATCH v3 2/5] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Amit Shah
2011-04-12 11:43 ` [Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for commonly-used field types Amit Shah
2011-04-12 13:10   ` Markus Armbruster
2011-04-12 14:00     ` Amit Shah
2011-04-12 11:43 ` [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions Amit Shah
2011-04-12 13:09   ` Kevin Wolf
2011-04-12 13:59     ` Amit Shah
2011-04-12 14:07       ` Kevin Wolf
2011-04-12 14:12         ` Amit Shah
2011-04-12 14:40           ` Paolo Bonzini
2011-04-12 11:43 ` [Qemu-devel] [PATCH v3 5/5] atapi: GESN: implement 'media' subcommand Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1302608369.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).