qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes
Date: Thu,  2 Jun 2011 13:53:35 +0200	[thread overview]
Message-ID: <cover.1307014902.git.quintela@redhat.com> (raw)

Hi

This series fixes compilation of plain:

./configure

with gcc-4.6.0 on Fedora 15.

Notes:
- linuxload.c: why it define id_change if it never test its value?
  git log shows that it has been this way forever
- linux-user/syscall.c: do we want to return an error in the default case?
  my guess is yes, but ...
- mips: it puts 8 arguments on the stack, but do_syscall() only uses 6.
  at least some syscalls uses already 7 arguments, I guess this has never worked before.

- for this kind of warnings, I have added:
   (void)unused_var;
  We can remove the variable altogether, comment it, use __attribute__(no_warn_unused).

- linux-user, syscall for alpha.  can anyone check tat my s/arg1/how/
  is the right change.  Looking at the normal sigprocmask call
  emulation, it looks like my change is wright, but one never knows.

Later, Juan.


Juan Quintela (14):
  kvm: remove fop write only variable
  tcg: define and set call_type only when it is used
  flatload: memp was a write-only variable
  xen: pentry is not used in this function
  linuxload: id_change was a write only variable
  flatload: end_code was only used in a debug message
  alpha: fn2 was a write only variable
  syscall: really return ret code
  exec: last_first_tb was only used in !ONLY_USER case
  mips: we really need the extra arguments
  linux-user: fpu_save_addr is not used
  linux-user: syscall should use sanitized arg1
  alpha: disp12 is not used for USER emulation
  lsi53c895a: current_dev is not used

 exec.c                   |   10 +++++++---
 hw/lsi53c895a.c          |    2 --
 linux-user/flatload.c    |    8 ++------
 linux-user/linuxload.c   |   25 +------------------------
 linux-user/main.c        |    4 ++++
 linux-user/signal.c      |    3 ++-
 linux-user/syscall.c     |   10 +++++-----
 target-alpha/translate.c |   10 +++++++---
 target-i386/kvm.c        |    3 +--
 tcg/tcg.c                |    9 +++------
 xen-mapcache.c           |    3 +--
 11 files changed, 33 insertions(+), 54 deletions(-)

-- 
1.7.5.2

             reply	other threads:[~2011-06-02 11:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 11:53 Juan Quintela [this message]
2011-06-02 11:53 ` [Qemu-devel] [PATCH 01/14] kvm: remove fop write only variable Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 02/14] tcg: define and set call_type only when it is used Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 03/14] flatload: memp was a write-only variable Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 04/14] xen: pentry is not used in this function Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 05/14] linuxload: id_change was a write only variable Juan Quintela
2011-06-10 17:04   ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 06/14] flatload: end_code was only used in a debug message Juan Quintela
2011-06-10 15:31   ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 07/14] alpha: fn2 was a write only variable Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 08/14] syscall: really return ret code Juan Quintela
2011-06-10 17:00   ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case Juan Quintela
2011-06-17 11:38   ` Peter Maydell
2011-06-24 14:42   ` Stefan Hajnoczi
2011-06-02 11:53 ` [Qemu-devel] [PATCH 10/14] mips: we really need the extra arguments Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used Juan Quintela
2011-06-02 13:51   ` Peter Maydell
2011-06-02 14:59     ` Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 12/14] linux-user: syscall should use sanitized arg1 Juan Quintela
2011-06-10 17:13   ` Peter Maydell
2011-06-02 11:53 ` [Qemu-devel] [PATCH 13/14] alpha: disp12 is not used for USER emulation Juan Quintela
2011-06-02 11:53 ` [Qemu-devel] [PATCH 14/14] lsi53c895a: current_dev is not used Juan Quintela
2011-06-02 12:24   ` Andreas Färber
2011-06-02 12:39     ` Juan Quintela
2011-06-02 13:05 ` [Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes Christophe Fergeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1307014902.git.quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).