From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjSGD-0006C1-8h for qemu-devel@nongnu.org; Wed, 20 Jul 2011 04:36:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjSGB-00038S-08 for qemu-devel@nongnu.org; Wed, 20 Jul 2011 04:36:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjSGA-00038A-El for qemu-devel@nongnu.org; Wed, 20 Jul 2011 04:36:02 -0400 From: Amit Shah Date: Wed, 20 Jul 2011 14:05:26 +0530 Message-Id: Subject: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Amit Shah , Markus Armbruster 'balloon 0' in the monitor causes a segfault. This happens because the function that handles change in balloon values is also tasked with handling stats retrieval from the guest, and it does the retrieval when the balloon target is '0'. Silly API, replace it. Also do a few cleanups along the way. Amit Shah (7): balloon: Make functions, local vars static balloon: Add braces around if statements balloon: Simplify code flow virtio-balloon: Separate status handling into separate function balloon: Separate out stat and balloon handling balloon: Fix header comment; add Copyright virtio-balloon: Fix header comment; add Copyright balloon.c | 47 +++++++++++++++++++++------------------ balloon.h | 12 ++++------ hw/virtio-balloon.c | 60 +++++++++++++++++++++++++++++--------------------- 3 files changed, 65 insertions(+), 54 deletions(-) -- 1.7.6