From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCzP0-00078Z-C4 for qemu-devel@nongnu.org; Sun, 09 Oct 2011 15:51:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RCzOx-0004az-4L for qemu-devel@nongnu.org; Sun, 09 Oct 2011 15:51:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCzOv-0004Zx-PD for qemu-devel@nongnu.org; Sun, 09 Oct 2011 15:51:10 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p99Jp7Hu001560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 9 Oct 2011 15:51:07 -0400 From: Juan Quintela Date: Sun, 9 Oct 2011 21:49:58 +0200 Message-Id: Subject: [Qemu-devel] [PATCH v4 0/5] Improve subsections detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi v4: - brown paperbug on qemu_file_skip() static void qemu_file_skip(QEMUFile *f, int size) { - if (f->buf_index + size < f->buf_size) { + if (f->buf_index + size <= f->buf_size) { f->buf_index += size; } } v3: - fix return value on qemu_get_buffer. Anthony, all reviewers comments are fixed, please consider to apply. Later, Juan. v2: - rename "used" to "remaining" (Alex suggestion) - implement qemu_get_{byte,buffer} on top of qemu_peek_{byte, buffer} (Anthony suggestion) - fix qemu_peek_buffe_logic (Alex discovered the problem) v1: This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look at the idstr and see that it starts with the subsection name. Please review. Later, Juan. *** BLURB HERE *** Juan Quintela (5): savevm: teach qemu_fill_buffer to do partial refills savevm: some coding style cleanups savevm: define qemu_get_byte() using qemu_peek_byte() savevm: improve subsections detection on load Revert "savevm: fix corruption in vmstate_subsection_load()." savevm.c | 144 ++++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 94 insertions(+), 50 deletions(-) -- 1.7.6.4