qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] balloon: error if guest driver is not initialised
Date: Fri,  9 Dec 2011 17:19:35 +0530	[thread overview]
Message-ID: <cover.1323431083.git.amit.shah@redhat.com> (raw)

Hello,

These patches make qemu generate an error on failure in setting a
balloon value:

(qemu) balloon 400
Device 'balloon' has not been activated

This can happen when the guest hasn't yet loaded a balloon driver.

Previously, such a ballooning attempt didn't produce an error, but the
virtio-balloon driver remembered the value nevertheless, causing a
module load in the guest using the attempted balloon value
originally.  This may not be the desired course of action.

I've re-used the QERR_DEVICE_NOT_ACTIVE error message, I think it fits
in this case too.  If not, let me know and I'll change it to something
else.

Please review and apply.

Amit Shah (3):
  balloon: Make functions return 0 on OK, -1 on error.
  balloon: report error if ballooning operation fails
  virtio-balloon: report error if balloon driver in guest not available

 balloon.c           |   19 ++++++++++++-------
 balloon.h           |    2 +-
 hw/virtio-balloon.c |    6 +++++-
 3 files changed, 18 insertions(+), 9 deletions(-)

-- 
1.7.7.3

             reply	other threads:[~2011-12-09 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09 11:49 Amit Shah [this message]
2011-12-09 11:49 ` [Qemu-devel] [PATCH 1/3] balloon: Make functions return 0 on OK, -1 on error Amit Shah
2011-12-09 11:49 ` [Qemu-devel] [PATCH 2/3] balloon: report error if ballooning operation fails Amit Shah
2011-12-09 11:49 ` [Qemu-devel] [PATCH 3/3] virtio-balloon: report error if balloon driver in guest not available Amit Shah
2011-12-09 11:55 ` [Qemu-devel] [PATCH 0/3] balloon: error if guest driver is not initialised Daniel P. Berrange
2011-12-09 12:02   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1323431083.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).