From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com, armbru@redhat.com,
lcapitulino@redhat.com, pbonzini@redhat.com, eblake@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/2] Group Live Snapshots
Date: Mon, 27 Feb 2012 19:33:41 -0500 [thread overview]
Message-ID: <cover.1330388514.git.jcody@redhat.com> (raw)
This patchset adds the ability to take a snapshot of a group of devices,
rather than each device individually. Upon failure of any snapshot, all
snapshots taken by the command will be abandoned, and the appropriate failure
code returned.
All the changes from v2 to v3 are in patch 1/2. This differs from v2 in that:
* Comments were added and clarified, as recommended by Stefan and Kevin
* In block.c:
- the assignment of the backing_hd was moved closer to the swap, for
clarity
- additional fields preserved (geometery, io stats, r/w error)
- more fields cleared in lower layer bs after the swap
* In blockdev.c:
- Removed the is_open field
- bdrv_drain_all() moved to the top of the function
- Error checking on bdrv_flush() (and no flush if it is read-only)
- Fixed mem leak scenarios
* In block_int.h:
- Note at the top of the BlockDriverState struct
Jeff Cody (2):
qapi: Introduce blockdev-group-snapshot-sync command
QMP: Add qmp command for blockdev-group-snapshot-sync
block.c | 80 ++++++++++++++++++++++++++++++++
block.h | 1 +
block_int.h | 6 +++
blockdev.c | 133 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
qapi-schema.json | 38 +++++++++++++++
qmp-commands.hx | 39 ++++++++++++++++
6 files changed, 297 insertions(+), 0 deletions(-)
--
1.7.9.rc2.1.g69204
next reply other threads:[~2012-02-28 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 0:33 Jeff Cody [this message]
2012-02-28 0:33 ` [Qemu-devel] [PATCH v3 1/2] qapi: Introduce blockdev-group-snapshot-sync command Jeff Cody
2012-02-28 11:57 ` Kevin Wolf
2012-02-28 0:33 ` [Qemu-devel] [PATCH v3 2/2] QMP: Add qmp command for blockdev-group-snapshot-sync Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1330388514.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).