From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3XgQ-0004kJ-Dz for qemu-devel@nongnu.org; Fri, 02 Mar 2012 13:58:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3XgO-0003xX-Et for qemu-devel@nongnu.org; Fri, 02 Mar 2012 13:58:25 -0500 Received: from thoth.sbs.de ([192.35.17.2]:31932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3XgO-0003wv-3i for qemu-devel@nongnu.org; Fri, 02 Mar 2012 13:58:24 -0500 From: Jan Kiszka Date: Fri, 2 Mar 2012 19:57:49 +0100 Message-Id: Subject: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , Zhi Yong Wu , Fabien Chouteau , "Michael S. Tsirkin" Well, this requeuing bug seems to have a long breath. Previous attempts to fix it (mine included) neglected the fact that we need to walk the queue of pending packets, not just restart from the beginning after a requeue. This version should get it Right(TM). This also comes with a fix for resource cleanups on slirp shutdown. At least valgrind is happy now. Changes in v2: - fixed corner case of session list walk that Stefan Weil reported CC: Fabien Chouteau CC: Michael S. Tsirkin CC: Stefan Weil CC: Zhi Yong Wu Jan Kiszka (4): slirp: Keep next_m always valid slirp: Fix queue walking in if_start slirp: Remove unneeded if_queued slirp: Cleanup resources on instance removal slirp/if.c | 64 +++++++++++++++++++++++++++++------------------------ slirp/ip_icmp.c | 7 ++++++ slirp/ip_icmp.h | 1 + slirp/ip_input.c | 7 ++++++ slirp/mbuf.c | 21 +++++++++++++++++ slirp/mbuf.h | 1 + slirp/slirp.c | 10 +++----- slirp/slirp.h | 3 +- slirp/tcp_subr.c | 7 ++++++ slirp/udp.c | 8 ++++++ slirp/udp.h | 1 + 11 files changed, 94 insertions(+), 36 deletions(-) -- 1.7.3.4