qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code
Date: Thu, 13 Dec 2012 16:07:52 +0530	[thread overview]
Message-ID: <cover.1355394885.git.amit.shah@redhat.com> (raw)

This series reworks the post_load code recently introduced to allocate
the structures only when required (i.e. only at load time).  This
helps keep the VirtIOSerial struct clean, and use less RAM.

Also rearrange the code in virtio_serial_load() for easier
readability.

Patch 4 fixes a race with the timer going off after a device got
hot-unplugged, and patch 1 uses unsigned int (uint32_t) type to count
ports, as in the rest of the code.

Please review.

Amit Shah (4):
  virtio-serial: use uint32_t to count ports
  virtio-serial: move active ports loading to separate function
  virtio-serial: allocate post_load only at load-time
  virtio-serial: delete timer if active during exit

 hw/virtio-serial-bus.c | 150 +++++++++++++++++++++++++++++--------------------
 1 file changed, 89 insertions(+), 61 deletions(-)

-- 
1.8.0.2

             reply	other threads:[~2012-12-13 10:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 10:37 Amit Shah [this message]
2012-12-13 10:37 ` [Qemu-devel] [PATCH 1/4] virtio-serial: use uint32_t to count ports Amit Shah
2012-12-14  5:18   ` Rob Landley
2012-12-13 10:37 ` [Qemu-devel] [PATCH 2/4] virtio-serial: move active ports loading to separate function Amit Shah
2012-12-13 10:37 ` [Qemu-devel] [PATCH 3/4] virtio-serial: allocate post_load only at load-time Amit Shah
2012-12-13 10:37 ` [Qemu-devel] [PATCH 4/4] virtio-serial: delete timer if active during exit Amit Shah
2012-12-13 10:46 ` [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1355394885.git.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).