From: Miroslav Rezanina <mrezanin@redhat.com>
To: qemu-devel@nongnu.org
Cc: Miroslav Rezanina <mrezanin@redhat.com>
Subject: [Qemu-devel] [PATCH v8 0/4] Add subcommand compare for qemu-img
Date: Mon, 14 Jan 2013 11:26:05 +0100 [thread overview]
Message-ID: <cover.1358148502.git.mrezanin@redhat.com> (raw)
In-Reply-To: <1355751593-31535-1-git-send-email-mrezanin@redhat.com>
In-Reply-To: <1355751593-31535-1-git-send-email-mrezanin@redhat.com>
This is 8th version of patch adding compare subcommand that
compares two images. Compare has following criteria:
- only data part is compared
- unallocated sectors are not read
- in case of different image size, exceeding part of bigger disk has
to be zeroed/unallocated to compare rest
- qemu-img returns:
- 0 if images are identical
- 1 if images differ
- 2 on error
v8:
- minor grammar fixes (no behavior change)
v7:
- split patch into pieces
- Quiet mode added for all relevant subcommands
- check non-shared part of disk after shared one
- minor docummentation and naming fixes
v6:
- added handling -?, -h options for compare subcommand
v5 (only minor changes):
- removed redundant comment
- removed dead code (goto after help())
- set final total_sectors on first assignment
v4:
- Fixed various typos
- Added functions for empty sector check and sector-to-bytes offset
conversion
- Fixed command-line parameters processing
v3:
- options -f/-F are orthogonal
- documentation updated to new syntax and behavior
- used byte offset instead of sector number for output
v2:
- changed option for second image format to -F
- changed handling of -f and -F [1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Miroslav Rezanina (4):
block: Add synchronous wrapper for bdrv_co_is_allocated_above
qemu-img: Add "Quiet mode" option
qemu-img: Add compare subcommand
Add qemu-img compare documentation
block.c | 51 ++++++-
blockdev.c | 6 +-
include/block/block.h | 5 +-
qemu-img-cmds.hx | 34 +++--
qemu-img.c | 381 +++++++++++++++++++++++++++++++++++++++++++++----
qemu-img.texi | 35 +++++
6 files changed, 461 insertions(+), 51 deletions(-)
next prev parent reply other threads:[~2013-01-14 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 13:39 [Qemu-devel] [PATCH v7 0/4] Add subcommand compare for qemu-img mrezanin
2012-12-17 13:39 ` [Qemu-devel] [PATCH v7 1/4] block: Add synchronous wrapper for bdrv_co_is_allocated_above mrezanin
2012-12-17 13:39 ` [Qemu-devel] [PATCH v7 2/4] qemu-img: Add "Quiet mode" option mrezanin
2012-12-17 13:39 ` [Qemu-devel] [PATCH v7 3/4] qemu-img: Add compare subcommand mrezanin
2012-12-17 13:39 ` [Qemu-devel] [PATCH v7 4/4] Add qemu-img compare documentation mrezanin
2012-12-19 18:15 ` Eric Blake
2012-12-20 19:46 ` Miroslav Rezanina
2012-12-19 18:12 ` [Qemu-devel] [PATCH v7 3/4] qemu-img: Add compare subcommand Eric Blake
2012-12-20 19:44 ` Miroslav Rezanina
2012-12-19 18:06 ` [Qemu-devel] [PATCH v7 2/4] qemu-img: Add "Quiet mode" option Eric Blake
2012-12-20 19:31 ` Miroslav Rezanina
2012-12-19 17:54 ` [Qemu-devel] [PATCH v7 1/4] block: Add synchronous wrapper for bdrv_co_is_allocated_above Eric Blake
2013-01-14 10:26 ` Miroslav Rezanina [this message]
2013-01-14 10:26 ` [Qemu-devel] [PATCH v8 " Miroslav Rezanina
2013-01-14 21:33 ` Eric Blake
2013-01-14 10:26 ` [Qemu-devel] [PATCH v8 2/4] qemu-img: Add "Quiet mode" option Miroslav Rezanina
2013-01-14 23:01 ` Eric Blake
2013-01-14 10:26 ` [Qemu-devel] [PATCH v8 3/4] qemu-img: Add compare subcommand Miroslav Rezanina
2013-01-14 10:26 ` [Qemu-devel] [PATCH v8 4/4] Add qemu-img compare documentation Miroslav Rezanina
2013-01-14 23:24 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1358148502.git.mrezanin@redhat.com \
--to=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).