From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuhFF-0001NG-TN for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:26:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuhF9-0005MF-BC for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:26:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuhF9-0005Lf-4G for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:26:15 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0EAQEC9015686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Jan 2013 05:26:14 -0500 From: Miroslav Rezanina Date: Mon, 14 Jan 2013 11:26:05 +0100 Message-Id: In-Reply-To: <1355751593-31535-1-git-send-email-mrezanin@redhat.com> References: <1355751593-31535-1-git-send-email-mrezanin@redhat.com> In-Reply-To: <1355751593-31535-1-git-send-email-mrezanin@redhat.com> References: <1355751593-31535-1-git-send-email-mrezanin@redhat.com> Subject: [Qemu-devel] [PATCH v8 0/4] Add subcommand compare for qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Miroslav Rezanina This is 8th version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be zeroed/unallocated to compare rest - qemu-img returns: - 0 if images are identical - 1 if images differ - 2 on error v8: - minor grammar fixes (no behavior change) v7: - split patch into pieces - Quiet mode added for all relevant subcommands - check non-shared part of disk after shared one - minor docummentation and naming fixes v6: - added handling -?, -h options for compare subcommand v5 (only minor changes): - removed redundant comment - removed dead code (goto after help()) - set final total_sectors on first assignment v4: - Fixed various typos - Added functions for empty sector check and sector-to-bytes offset conversion - Fixed command-line parameters processing v3: - options -f/-F are orthogonal - documentation updated to new syntax and behavior - used byte offset instead of sector number for output v2: - changed option for second image format to -F - changed handling of -f and -F [1] - added strict mode (-s) - added quiet mode (-q) - improved output messages [2] - rename variables for larger image handling - added man page content Signed-off-by: Miroslav Rezanina Miroslav Rezanina (4): block: Add synchronous wrapper for bdrv_co_is_allocated_above qemu-img: Add "Quiet mode" option qemu-img: Add compare subcommand Add qemu-img compare documentation block.c | 51 ++++++- blockdev.c | 6 +- include/block/block.h | 5 +- qemu-img-cmds.hx | 34 +++-- qemu-img.c | 381 +++++++++++++++++++++++++++++++++++++++++++++---- qemu-img.texi | 35 +++++ 6 files changed, 461 insertions(+), 51 deletions(-)