From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULa2u-0002CV-25 for qemu-devel@nongnu.org; Fri, 29 Mar 2013 10:12:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULa2s-0003Ts-Vt for qemu-devel@nongnu.org; Fri, 29 Mar 2013 10:12:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULa2s-0003RA-Ny for qemu-devel@nongnu.org; Fri, 29 Mar 2013 10:12:42 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2TECf01013556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 29 Mar 2013 10:12:41 -0400 From: Pavel Hrdina Date: Fri, 29 Mar 2013 15:12:27 +0100 Message-Id: Subject: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: phrdina@redhat.com, armbru@redhat.com, lcapitulino@redhat.com This patch series convert the savevm command into qapi and introduce QMP command vm-snapshot-save. It also rewrite error report for functions used by this command. The last patch introduce new functionality of savevm that you cannot override existing snapshot without using 'force' parameter. If non-blocking behaviour of this command is required and we cannot wait until live snapshots will be finished, I could improve this basic command to be non-blocking. Changes from v3: - correct hopefully all error messages - proper commit message for 'qapi: Convert savevm' Changes from v2: - correct error messages - introduce of 'force' option moved to qapi: Convert savevm - update of return value for used functions - drop of the speed improve because it isn't actually speed improve - vm-snapshot-save and savevm now returns snapshot information Changes from v1: - rebase on current master branch - improve the speed of savevm - name parameter remains optionl for HMP and QMP Pavel Hrdina (11): block: add error parameter to bdrv_snapshot_create() and related functions block: add error parameter to del_existing_snapshots() savevm: add error parameter to qemu_savevm_state_begin() savevm: add error parameter to qemu_savevm_state_iterate() savevm: add error parameter to qemu_savevm_state_complete() savevm: add error parameter to qemu_savevm_state() qapi: Convert savevm qemu-img: introduce qemu_img_handle_error block: update return value from bdrv_snapshot_create savevm: update return value from qemu_savevm_state savevm: add force parameter to HMP command and return snapshot info block.c | 24 +++++++----- block/qcow2-snapshot.c | 15 +++++--- block/qcow2.h | 4 +- block/rbd.c | 19 +++++----- block/sheepdog.c | 20 +++++----- hmp-commands.hx | 18 ++++----- hmp.c | 27 ++++++++++++++ hmp.h | 1 + include/block/block.h | 5 ++- include/block/block_int.h | 5 ++- include/sysemu/sysemu.h | 8 ++-- migration.c | 6 +-- qapi-schema.json | 22 +++++++++++ qemu-img.c | 27 ++++++++------ qmp-commands.hx | 43 ++++++++++++++++++++++ savevm.c | 93 ++++++++++++++++++++++++++++------------------- 16 files changed, 235 insertions(+), 102 deletions(-) -- 1.8.1.4