[Qemu-devel] [PATCH arm-devs v1 0/1] cadence_uart: U-boot driver

[Qemu-devel] [PATCH arm-devs v1 0/1] cadence_uart: U-boot driver

[Peter Crosthwaite]

Hi Peter,

This is a corner case bug discovered by U-boot driver for cadence GEM.

Regards,
Peter


Peter Crosthwaite (1):
  cadence_uart: Flush queued characters on reset

 hw/cadence_uart.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH arm-devs v1 1/1] cadence_uart: Flush queued characters on reset

[Peter Crosthwaite]

Reset can be used to empty the rx-fifo. As the fifo full condition is
used to return false from can_receive, queued rx data should be flushed
on reset accordingly.

Cc: Wendy Liang <jliang@xilinx.com>
Cc: Jason Wu <huanyu@xilinx.com>

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reported-by: Jason Wu <huanyu@xilinx.com>
---

 hw/cadence_uart.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c
index 5426f10..421ec99 100644
--- a/hw/cadence_uart.c
+++ b/hw/cadence_uart.c
@@ -157,6 +157,7 @@ static void uart_rx_reset(UartState *s)
 {
     s->rx_wpos = 0;
     s->rx_count = 0;
+    qemu_chr_accept_input(s->chr);
 
     s->r[R_SR] |= UART_SR_INTR_REMPTY;
     s->r[R_SR] &= ~UART_SR_INTR_RFUL;
-- 
1.7.0.4

Re: [Qemu-devel] [PATCH arm-devs v1 1/1] cadence_uart: Flush queued characters on reset

[Peter Maydell]

On 3 April 2013 05:52, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> Reset can be used to empty the rx-fifo. As the fifo full condition is
> used to return false from can_receive, queued rx data should be flushed
> on reset accordingly.
>
> Cc: Wendy Liang <jliang@xilinx.com>
> Cc: Jason Wu <huanyu@xilinx.com>
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Reported-by: Jason Wu <huanyu@xilinx.com>

Thanks, applied to arm-devs.next.

-- PMM