From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhj4x-0004Bm-Tr for qemu-devel@nongnu.org; Wed, 29 May 2013 12:18:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhj4w-00034Z-Ol for qemu-devel@nongnu.org; Wed, 29 May 2013 12:18:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhj4w-00034S-GD for qemu-devel@nongnu.org; Wed, 29 May 2013 12:18:22 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TGILmZ010723 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 12:18:21 -0400 From: Pavel Hrdina Date: Wed, 29 May 2013 18:18:17 +0200 Message-Id: Subject: [Qemu-devel] [PATCH v2 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, lcapitulino@redhat.com This fixes a regression introduced by commit 9ca111544. The first commit is done by Luiz and I've just use it as it is. The second commit moves the bdrv_dev_change_media_cb() into eject_device(), called by QMP and HMP eject command, and into qmp_bdrv_open_encrypted(), called by QMP and HMP change command. These are the only place where I think that should call the bdrv_dev_change_media_cb() function. There is no reason to call this function while we are removing the device from the guest, for example while closing and deleting all devices on shutdown. Luiz Capitulino (1): block: make bdrv_dev_change_media_cb() public Pavel Hrdina (1): block: move the bdrv_dev_change_media_cb() block.c | 11 +---------- blockdev.c | 5 +++++ include/block/block.h | 1 + 3 files changed, 7 insertions(+), 10 deletions(-) -- 1.8.1.4