qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Hrdina <phrdina@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com, phrdina@redhat.com,
	lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown
Date: Mon, 17 Jun 2013 15:21:39 +0200	[thread overview]
Message-ID: <cover.1371474572.git.phrdina@redhat.com> (raw)

This fixes a regression introduced by commit 9ca111544.

The first commit is done by Luiz and I've just use it as it is.

The second commit moves the bdrv_dev_change_media_cb() into eject_device(),
called by QMP and HMP eject command, and into qmp_bdrv_open_encrypted(),
called by QMP and HMP change command. These are the only place where I think
that should call the bdrv_dev_change_media_cb() function.

There is no reason to call this function while we are removing the device
from the guest, for example while closing and deleting all devices on shutdown.

* changes from v1:
    - used the first patch from Luiz's series

* changes from v2:
    - added comment that the error QERR_DEVICE_NOT_ENCRYPTED is used as warning

Luiz Capitulino (1):
  block: make bdrv_dev_change_media_cb() public

Pavel Hrdina (1):
  block: move the bdrv_dev_change_media_cb()

 block.c               | 11 +----------
 blockdev.c            |  7 +++++++
 include/block/block.h |  1 +
 3 files changed, 9 insertions(+), 10 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-06-17 13:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 13:21 Pavel Hrdina [this message]
2013-06-17 13:21 ` [Qemu-devel] [PATCH v3 1/2] block: make bdrv_dev_change_media_cb() public Pavel Hrdina
2013-06-17 13:21 ` [Qemu-devel] [PATCH v3 2/2] block: move the bdrv_dev_change_media_cb() Pavel Hrdina
2013-06-19 10:16   ` Stefan Hajnoczi
2013-06-20 14:06     ` Pavel Hrdina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1371474572.git.phrdina@redhat.com \
    --to=phrdina@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).