[Qemu-devel] [RFC PATCH 0/6] pci cleanup: remove pci_config_set_*

[Hu Tao <hutao@cn.fujitsu.com>]

Hi,

This series removes pci_config_set_*.  The main purpose is for API
consistency. Detailed reasons:

  - pci_config_set_* are not complete. 1) Only part of registers in
    predefined header portion of PCI Configuration Space are
    supported. 2) Lack of get_ counterparts.

  - pci_set_word() and friends are extensively used in qemu. They
    are used both for predefined registers and device specific
    registers.

  - another option is to complete the pci_config_set_* for all
    predefined registers (though they will co-exist with pci_set_*).
    Hence the RFC.

Hu Tao (6):
  pci: remove pci_config_set_vendor_id
  pci: remove pci_config_set_device_id
  pci: remove pci_config_set_revision
  pci: remove pci_config_set_class
  pci: remove pci_config_set_prog_interface
  pci: remove pci_config_set_interrupt_pin

 hw/audio/intel-hda.c       |  2 +-
 hw/block/nvme.c            |  4 ++--
 hw/i2c/smbus_ich9.c        |  2 +-
 hw/i386/xen/xen_platform.c |  2 +-
 hw/i386/xen/xen_pvdevice.c |  2 +-
 hw/ide/ich.c               |  4 ++--
 hw/ide/via.c               |  2 +-
 hw/isa/i82378.c            |  2 +-
 hw/isa/vt82c686.c          |  2 +-
 hw/mips/gt64xxx_pci.c      |  2 +-
 hw/misc/ivshmem.c          |  2 +-
 hw/misc/vfio.c             |  2 +-
 hw/pci-bridge/i82801b11.c  |  2 +-
 hw/pci-host/bonito.c       |  2 +-
 hw/pci-host/ppce500.c      |  2 +-
 hw/pci/pci.c               |  8 ++++----
 hw/pci/pci_bridge.c        |  2 +-
 hw/scsi/vmw_pvscsi.c       |  2 +-
 hw/usb/hcd-uhci.c          |  2 +-
 hw/virtio/virtio-pci.c     |  2 +-
 include/hw/pci/pci.h       | 36 ------------------------------------
 21 files changed, 25 insertions(+), 61 deletions(-)

-- 
1.9.3