qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer
Date: Thu, 22 Jan 2015 08:03:24 -0500	[thread overview]
Message-ID: <cover.1421931293.git.jcody@redhat.com> (raw)

The block layer uses a mixture of 'PATH_MAX' and '1024' string sizes
for filenames (and backing filenames).

This series consolidates all that usage to 'PATH_MAX'.  Since most platforms
(especially the most common platforms for QEMU) have a PATH_MAX larger than
1024 bytes, this series also changes stack allocations of PATH_MAX to be
dynamically allocated.

Note: checkpatch.pl complains about an extra space in a printf in
      patches 1 & 2.  The lines complained about are in the diff context and
      not the actual changes, so I did not fix them up to satisfy checkpatch.

Changes from v3:
    - simplified extent_path handling in vmdk_parse_extents() (Thanks Stefan)
    - moved declaration of backing_filename2 to inside if
      statement in bdrv_query_image_info() (Thanks Stefan)
    - removed zombie variable in bdrv_commit (Thanks Stefan)
    - fixed typo in commit message (Thanks Stefan)

Changes from v2:

    - Change stack allocations to dybnamic (Thanks Kevin)
    - Update qcow/qcow2 ti perform safety checks for platforms that
      have a PATH_MAX < 1024 (thanks John, Kevin).

Jeff Cody (6):
  block: vmdk - make ret variable usage clear
  block: vmdk - move string allocations from stack to the heap
  block: qapi - move string allocation from stack to the heap
  block: remove unused variable in bdrv_commit
  block: mirror - change string allocation to 2-bytes
  block: update string sizes for filename,backing_file,exact_filename

 block.c                   |  3 ---
 block/mirror.c            |  3 ++-
 block/qapi.c              |  7 ++++---
 block/qcow.c              |  2 +-
 block/qcow2.c             |  3 ++-
 block/vmdk.c              | 51 ++++++++++++++++++++++++++++-------------------
 block/vvfat.c             |  4 ++--
 include/block/block_int.h |  8 ++++----
 qemu-img.c                |  4 ++--
 9 files changed, 47 insertions(+), 38 deletions(-)

-- 
1.9.3

             reply	other threads:[~2015-01-22 13:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 13:03 Jeff Cody [this message]
2015-01-22 13:03 ` [Qemu-devel] [PATCH v3 1/6] block: vmdk - make ret variable usage clear Jeff Cody
2015-01-22 13:03 ` [Qemu-devel] [PATCH v3 2/6] block: vmdk - move string allocations from stack to the heap Jeff Cody
2015-02-10 17:55   ` Paolo Bonzini
2015-01-22 13:03 ` [Qemu-devel] [PATCH v3 3/6] block: qapi - move string allocation " Jeff Cody
2015-01-22 13:03 ` [Qemu-devel] [PATCH v3 4/6] block: remove unused variable in bdrv_commit Jeff Cody
2015-01-22 13:03 ` [Qemu-devel] [PATCH v3 5/6] block: mirror - change string allocation to 2-bytes Jeff Cody
2015-01-22 13:03 ` [Qemu-devel] [PATCH v3 6/6] block: update string sizes for filename, backing_file, exact_filename Jeff Cody
2015-01-23 13:36 ` [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1421931293.git.jcody@redhat.com \
    --to=jcody@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).