From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEHQ9-0002IU-SZ for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:03:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEHQ5-0000Sy-Tn for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:03:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEHQ5-0000St-Lq for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:03:33 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MD3WFP009493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 22 Jan 2015 08:03:33 -0500 From: Jeff Cody Date: Thu, 22 Jan 2015 08:03:24 -0500 Message-Id: Subject: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, stefanha@redhat.com The block layer uses a mixture of 'PATH_MAX' and '1024' string sizes for filenames (and backing filenames). This series consolidates all that usage to 'PATH_MAX'. Since most platforms (especially the most common platforms for QEMU) have a PATH_MAX larger than 1024 bytes, this series also changes stack allocations of PATH_MAX to be dynamically allocated. Note: checkpatch.pl complains about an extra space in a printf in patches 1 & 2. The lines complained about are in the diff context and not the actual changes, so I did not fix them up to satisfy checkpatch. Changes from v3: - simplified extent_path handling in vmdk_parse_extents() (Thanks Stefan) - moved declaration of backing_filename2 to inside if statement in bdrv_query_image_info() (Thanks Stefan) - removed zombie variable in bdrv_commit (Thanks Stefan) - fixed typo in commit message (Thanks Stefan) Changes from v2: - Change stack allocations to dybnamic (Thanks Kevin) - Update qcow/qcow2 ti perform safety checks for platforms that have a PATH_MAX < 1024 (thanks John, Kevin). Jeff Cody (6): block: vmdk - make ret variable usage clear block: vmdk - move string allocations from stack to the heap block: qapi - move string allocation from stack to the heap block: remove unused variable in bdrv_commit block: mirror - change string allocation to 2-bytes block: update string sizes for filename,backing_file,exact_filename block.c | 3 --- block/mirror.c | 3 ++- block/qapi.c | 7 ++++--- block/qcow.c | 2 +- block/qcow2.c | 3 ++- block/vmdk.c | 51 ++++++++++++++++++++++++++++------------------- block/vvfat.c | 4 ++-- include/block/block_int.h | 8 ++++---- qemu-img.c | 4 ++-- 9 files changed, 47 insertions(+), 38 deletions(-) -- 1.9.3