From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support
Date: Fri, 13 Feb 2015 18:06:08 +0200 [thread overview]
Message-ID: <cover.1423842044.git.berto@igalia.com> (raw)
Hello,
after having agreed it with him, I'm taking over Benoît Canet's work
to add support for throttle groups for block devices.
This was the last version of the patches, as written by him:
https://lists.gnu.org/archive/html/qemu-devel/2014-10/msg00727.html
I rebased the patches and made a few changes, including some of the
suggestions that were proposed in the mailing list back then from Fam
Zheng and Eric Blake:
- The main function, bdrv_io_limits_update_group(), has been
significantly rewritten. The algorithm is essentially the same but
the code is hopefully more readable and easy to understand now.
- I replaced the magic numbers in test_groups() with actual objects
allocated using bdrv_new().
- I bumped the version number in the documentation changes from 2.2 to
2.3.
- I fixed a few typos and made other minor style changes.
- I added the name of the throttle group to BlockDeviceInfo, so now it
can be seen from the monitor.
I kept the authorship of the original patches except the one that I
had to modify substantially.
Regards,
Berto
Alberto Garcia (2):
throttle: Add throttle group support
throttle: add name of ThrottleGroup to BlockDeviceInfo
Benoît Canet (7):
throttle: Extract timers from ThrottleState into a separate
ThrottleTimers structure
throttle: Add throttle group infrastructure
throttle: Add throttle group infrastructure tests
throttle: Prepare to have multiple timers for one ThrottleState
throttle: Add a way to know if throttle_schedule_timer had armed a
timer
throttle: Add a way to fire one of the timers asap like a bottom half
throttle: Update throttle infrastructure copyright
block.c | 226 ++++++++++++++++++++++++++++++++++------
block/Makefile.objs | 1 +
block/qapi.c | 12 ++-
block/throttle-groups.c | 206 ++++++++++++++++++++++++++++++++++++
blockdev.c | 19 +++-
hmp.c | 10 +-
include/block/block.h | 3 +-
include/block/block_int.h | 9 +-
include/block/throttle-groups.h | 45 ++++++++
include/qemu/throttle.h | 48 ++++++---
qapi/block-core.json | 9 +-
qemu-options.hx | 1 +
qmp-commands.hx | 3 +-
tests/test-throttle.c | 142 ++++++++++++++++++-------
util/throttle.c | 106 ++++++++++++-------
15 files changed, 704 insertions(+), 136 deletions(-)
create mode 100644 block/throttle-groups.c
create mode 100644 include/block/throttle-groups.h
--
2.1.4
next reply other threads:[~2015-02-13 16:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 16:06 Alberto Garcia [this message]
2015-02-13 16:06 ` [Qemu-devel] [PATCH 1/9] throttle: Extract timers from ThrottleState into a separate ThrottleTimers structure Alberto Garcia
2015-03-03 16:03 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 2/9] throttle: Add throttle group infrastructure Alberto Garcia
2015-03-03 16:38 ` Stefan Hajnoczi
2015-03-04 10:18 ` Alberto Garcia
2015-03-04 16:02 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 3/9] throttle: Add throttle group infrastructure tests Alberto Garcia
2015-02-13 16:06 ` [Qemu-devel] [PATCH 4/9] throttle: Prepare to have multiple timers for one ThrottleState Alberto Garcia
2015-03-03 16:50 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 5/9] throttle: Add a way to know if throttle_schedule_timer had armed a timer Alberto Garcia
2015-02-13 16:06 ` [Qemu-devel] [PATCH 6/9] throttle: Add a way to fire one of the timers asap like a bottom half Alberto Garcia
2015-03-03 17:08 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support Alberto Garcia
2015-02-24 16:45 ` Eric Blake
2015-02-24 16:47 ` Eric Blake
2015-03-03 21:00 ` Stefan Hajnoczi
2015-03-04 13:53 ` Alberto Garcia
2015-03-04 16:04 ` Stefan Hajnoczi
2015-03-04 16:16 ` Alberto Garcia
2015-03-05 17:41 ` Stefan Hajnoczi
2015-02-13 16:06 ` [Qemu-devel] [PATCH 8/9] throttle: Update throttle infrastructure copyright Alberto Garcia
2015-02-24 16:49 ` Eric Blake
2015-02-24 20:21 ` Benoît Canet
2015-02-13 16:06 ` [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo Alberto Garcia
2015-02-24 16:54 ` Eric Blake
2015-02-25 10:56 ` Alberto Garcia
2015-02-25 15:23 ` Eric Blake
2015-02-25 15:37 ` Alberto Garcia
2015-02-26 13:56 ` Alberto Garcia
2015-03-03 17:53 ` Eric Blake
2015-03-04 7:09 ` Markus Armbruster
2015-03-04 7:20 ` Alberto Garcia
2015-03-03 21:07 ` [Qemu-devel] [PATCH v2 0/9] Block Throttle Group Support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1423842044.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).