From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 0/3] Add bdrv_get_device_or_node_name()
Date: Wed, 8 Apr 2015 12:29:17 +0300 [thread overview]
Message-ID: <cover.1428485266.git.berto@igalia.com> (raw)
This series contains a couple of minor changes suggested by Markus in
the previous one. I removed the Reviewed-by line by Max in the
modified patch even if the changes are small, hope that's ok.
v4:
- Fix documentation of the 'node-name' field in BLOCK_IMAGE_CORRUPTED.
Its annotation is now (json-string, optional).
- Clarify that the 'device' field can be empty even if it's always
present for compatibility reasons.
v3:
- The node-name field in BLOCK_IMAGE_CORRUPTED is now Since: 2.4
- Remove the QERR_ macros instead of updating them. The text message
is adapted to each case where applicable, and 'device' is renamed to
'node' only where it makes sense.
v2:
- bdrv_get_device_or_node_name() includes a comment explaining its
usage.
- The error messages have been updated to say 'node' instead of
'device' where appropriate.
- The BLOCK_IMAGE_CORRUPTED event has a new 'node-name' field.
Regards,
Berto
Alberto Garcia (3):
block: add bdrv_get_device_or_node_name()
block: use bdrv_get_device_or_node_name() in error messages
block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED
block.c | 33 +++++++++++++++++++++------------
block/qcow.c | 8 ++++----
block/qcow2.c | 10 +++++++---
block/qed.c | 2 +-
block/quorum.c | 5 +----
block/snapshot.c | 12 ++++++------
block/vdi.c | 6 +++---
block/vhdx.c | 6 +++---
block/vmdk.c | 8 ++++----
block/vpc.c | 6 +++---
block/vvfat.c | 7 ++++---
blockdev.c | 9 +++++----
docs/qmp/qmp-events.txt | 21 +++++++++++++--------
include/block/block.h | 1 +
include/qapi/qmp/qerror.h | 6 ------
qapi/block-core.json | 17 +++++++++++------
16 files changed, 87 insertions(+), 70 deletions(-)
--
2.1.4
next reply other threads:[~2015-04-08 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 9:29 Alberto Garcia [this message]
2015-04-08 9:29 ` [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name() Alberto Garcia
2015-04-08 16:32 ` Eric Blake
2015-04-08 9:29 ` [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages Alberto Garcia
2015-04-08 16:27 ` Eric Blake
2015-04-09 8:25 ` Alberto Garcia
2015-04-08 9:29 ` [Qemu-devel] [PATCH 3/3] block: add 'node-name' field to BLOCK_IMAGE_CORRUPTED Alberto Garcia
2015-04-08 23:32 ` Eric Blake
2015-04-09 7:30 ` Alberto Garcia
2015-04-15 13:24 ` Max Reitz
2015-04-21 13:47 ` [Qemu-devel] [Qemu-block] [PATCH v4 0/3] Add bdrv_get_device_or_node_name() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1428485266.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).