* [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30
@ 2015-04-30 13:10 Michael Tokarev
2015-04-30 13:10 ` [Qemu-devel] [PULL 42/42] openrisc: cpu: Remove unused cpu_get_pc Michael Tokarev
2015-04-30 17:03 ` [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Peter Maydell
0 siblings, 2 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-04-30 13:10 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael Tokarev
Another attempt, now without the problematic ARRAY_SIZE removal,
but with additional patch removing the unused cpu_get_pc(), and
with additional Reviewed-by.
Resending only the newly added patch, not whole series.
Thanks,
/mjt
The following changes since commit 06feaacfb4cfef10cc0c93d97df7bfc8a71dbc7e:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-04-30 12:04:11 +0100)
are available in the git repository at:
git://git.corpit.ru/qemu.git tags/pull-trivial-patches-2015-04-30
for you to fetch changes up to 553029351bac9f5b4f9ea72793e55f02e7677ec2:
openrisc: cpu: Remove unused cpu_get_pc (2015-04-30 16:06:18 +0300)
----------------------------------------------------------------
trivial patches for 2015-04-30
----------------------------------------------------------------
Chih-Min Chao (5):
bitops : fix coding style
ui/vnc : fix coding style
ui/vnc : remove 'struct' of 'typedef struct'
ui/console : remove 'struct' from 'typedef struct' type
hw/display : remove 'struct' from 'typedef QXL struct'
Emilio G. Cota (5):
cpus: use first_cpu macro instead of QTAILQ_FIRST(&cpus)
input: remove unused mouse_handlers list
qemu-char: remove unused list node from FDCharDriver
coroutine: remove unnecessary parentheses in qemu_co_queue_empty
linux-user/elfload: use QTAILQ_FOREACH instead of open-coding it
Gonglei (3):
target-mips: fix memory leak
vhost-user: remove superfluous '\n' around error_report()
microblaze: fix memory leak
Jan Kiszka (1):
hostmem: Fix mem-path property name in error report
John Snow (1):
qmp-commands: Fix typo
Laszlo Ersek (1):
docs/atomics.txt: fix two typos
Michael Tokarev (3):
qemu-options: trivial spelling fix (messsage)
libcacard: do not use full paths for include files in the same dir
microblaze: cpu: Renumber EXCP_* constants to close gap
Paolo Bonzini (3):
range: remove useless inclusions
qemu-config: remove stray inclusions of hw/ files
libcacard: stop including qemu-common.h
Peter Crosthwaite (10):
arm: cpu.h: Remove unused typdefs
configure: alphabetize tricore in target list
defconfigs: Piggyback microblazeel on microblaze
microblaze: mmu: Delete flip_um fn prototype
microblaze: cpu: Remote unused cpu_get_pc
microblaze: cpu: Remove unused CC_OP enum
microblaze: cpu: Delete EXCP_NMI
microblaze: cpu: delete unused cpu_interrupts_enabled
tcg: Delete unused cpu_pc_from_tb()
openrisc: cpu: Remove unused cpu_get_pc
Stefan Berger (3):
tpm: Cast 64bit variables to int when used in DPRINTF
tpm: Modify DPRINTF to enable -Wformat checking
tpm: fix coding style
Stefan Weil (1):
misc: Fix new collection of typos
Thomas Huth (6):
vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags()
pci: Remove unused function ich9_d2pbr_init()
monitor: Remove unused functions
usb: Remove unused functions
util: Remove unused functions
kvm: Silence warning from valgrind
backends/hostmem-file.c | 2 +-
configure | 4 +-
cpus.c | 2 +-
default-configs/microblazeel-softmmu.mak | 10 +----
dma-helpers.c | 1 -
docs/atomics.txt | 4 +-
hmp.h | 1 -
hw/acpi/pcihp.c | 1 -
hw/block/virtio-blk.c | 2 +-
hw/display/qxl.c | 2 +-
hw/i386/acpi-build.c | 1 -
hw/microblaze/boot.c | 13 ++++---
hw/mips/mips_fulong2e.c | 1 +
hw/mips/mips_malta.c | 1 +
hw/mips/mips_r4k.c | 1 +
hw/misc/edu.c | 2 +-
hw/net/virtio-net.c | 2 +-
hw/net/vmxnet_rx_pkt.c | 7 ----
hw/net/vmxnet_rx_pkt.h | 9 -----
hw/pci-bridge/i82801b11.c | 21 ----------
hw/ppc/spapr.c | 2 +-
hw/tpm/tpm_passthrough.c | 16 ++++----
hw/tpm/tpm_tis.c | 26 ++++++-------
hw/usb/core.c | 41 --------------------
hw/virtio/vhost-user.c | 22 +++++------
include/hw/i386/ich9.h | 2 -
include/hw/pci-host/q35.h | 1 -
include/hw/usb.h | 5 ---
include/monitor/monitor.h | 1 -
include/qemu-common.h | 4 --
include/qemu/bitops.h | 61 ++++++++++++++---------------
include/qemu/compatfd.h | 1 -
kvm-all.c | 14 +++----
libcacard/cac.c | 5 ++-
libcacard/card_7816.c | 4 +-
libcacard/event.c | 2 +-
libcacard/vcard.c | 4 +-
libcacard/vcard_emul_nss.c | 4 +-
libcacard/vcardt.c | 4 +-
libcacard/vreader.c | 4 +-
libcacard/vscclient.c | 8 +++-
linux-user/elfload.c | 3 +-
monitor.c | 13 -------
qemu-char.c | 1 -
qemu-coroutine-lock.c | 2 +-
qemu-options.hx | 2 +-
qga/qapi-schema.json | 2 +-
qmp-commands.hx | 4 +-
target-arm/cpu.h | 14 -------
target-microblaze/cpu.h | 27 +++----------
target-microblaze/mmu.h | 1 -
target-openrisc/cpu.h | 5 ---
target-s390x/mmu_helper.c | 8 ++--
target-s390x/translate.c | 2 +-
target-tricore/cpu.h | 5 ---
tcg/tcg.h | 6 ++-
tests/libqos/ahci.c | 4 +-
ui/console.c | 4 +-
ui/input-legacy.c | 2 -
ui/spice-display.c | 8 ++--
ui/vnc-auth-vencrypt.c | 8 ++--
ui/vnc-tls.c | 10 ++---
ui/vnc-ws.c | 4 +-
ui/vnc.c | 2 +-
util/compatfd.c | 19 ---------
util/osdep.c | 66 --------------------------------
util/qemu-config.c | 2 -
67 files changed, 156 insertions(+), 386 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] [PULL 42/42] openrisc: cpu: Remove unused cpu_get_pc
2015-04-30 13:10 [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Michael Tokarev
@ 2015-04-30 13:10 ` Michael Tokarev
2015-04-30 17:03 ` [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Peter Maydell
1 sibling, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-04-30 13:10 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Peter Crosthwaite, Michael Tokarev,
Peter Crosthwaite
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
This function is not used by anything. Remove.
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
target-openrisc/cpu.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h
index b25324b..9e23cd0 100644
--- a/target-openrisc/cpu.h
+++ b/target-openrisc/cpu.h
@@ -415,9 +415,4 @@ static inline int cpu_mmu_index(CPUOpenRISCState *env)
#include "exec/exec-all.h"
-static inline target_ulong cpu_get_pc(CPUOpenRISCState *env)
-{
- return env->pc;
-}
-
#endif /* CPU_OPENRISC_H */
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30
2015-04-30 13:10 [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Michael Tokarev
2015-04-30 13:10 ` [Qemu-devel] [PULL 42/42] openrisc: cpu: Remove unused cpu_get_pc Michael Tokarev
@ 2015-04-30 17:03 ` Peter Maydell
1 sibling, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2015-04-30 17:03 UTC (permalink / raw)
To: Michael Tokarev; +Cc: QEMU Trivial, QEMU Developers
On 30 April 2015 at 14:10, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Another attempt, now without the problematic ARRAY_SIZE removal,
> but with additional patch removing the unused cpu_get_pc(), and
> with additional Reviewed-by.
>
> Resending only the newly added patch, not whole series.
>
> Thanks,
>
> /mjt
>
> The following changes since commit 06feaacfb4cfef10cc0c93d97df7bfc8a71dbc7e:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-04-30 12:04:11 +0100)
>
> are available in the git repository at:
>
> git://git.corpit.ru/qemu.git tags/pull-trivial-patches-2015-04-30
>
> for you to fetch changes up to 553029351bac9f5b4f9ea72793e55f02e7677ec2:
>
> openrisc: cpu: Remove unused cpu_get_pc (2015-04-30 16:06:18 +0300)
>
> ----------------------------------------------------------------
> trivial patches for 2015-04-30
>
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30
@ 2015-04-30 5:08 Michael Tokarev
2015-04-30 12:58 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Michael Tokarev @ 2015-04-30 5:08 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael Tokarev
Hello.
This is the first pull request for trivial-patches tree since 2.3 has
been released. During the freeze many patches has been accumulated,
and even more has been received after 2.4 developmnent has been opened.
So here we have 42 trivial patches, which is kinda too much, but that's
what we have :)
Please consider applying.
Thanks,
/mjt
The following changes since commit a9392bc93c8615ad1983047e9f91ee3fa8aae75f:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-04-28 16:55:03 +0100)
are available in the git repository at:
git://git.corpit.ru/qemu.git tags/pull-trivial-patches-2015-04-30
for you to fetch changes up to fe31d3e6e6945b509e5b4ab03d38aae1266fe64e:
microblaze: fix memory leak (2015-04-30 08:06:20 +0300)
----------------------------------------------------------------
trivial patches for 2015-04-30
----------------------------------------------------------------
Chih-Min Chao (5):
bitops : fix coding style
ui/vnc : fix coding style
ui/vnc : remove 'struct' of 'typedef struct'
ui/console : remove 'struct' from 'typedef struct' type
hw/display : remove 'struct' from 'typedef QXL struct'
Emilio G. Cota (6):
cpus: use first_cpu macro instead of QTAILQ_FIRST(&cpus)
input: remove unused mouse_handlers list
qemu-char: remove unused list node from FDCharDriver
coroutine: remove unnecessary parentheses in qemu_co_queue_empty
linux-user/elfload: use QTAILQ_FOREACH instead of open-coding it
i440fx-test: remove ARRAY_SIZE redefinition
Gonglei (3):
target-mips: fix memory leak
vhost-user: remove superfluous '\n' around error_report()
microblaze: fix memory leak
Jan Kiszka (1):
hostmem: Fix mem-path property name in error report
John Snow (1):
qmp-commands: Fix typo
Laszlo Ersek (1):
docs/atomics.txt: fix two typos
Michael Tokarev (3):
qemu-options: trivial spelling fix (messsage)
libcacard: do not use full paths for include files in the same dir
microblaze: cpu: Renumber EXCP_* constants to close gap
Paolo Bonzini (3):
range: remove useless inclusions
qemu-config: remove stray inclusions of hw/ files
libcacard: stop including qemu-common.h
Peter Crosthwaite (9):
arm: cpu.h: Remove unused typdefs
configure: alphabetize tricore in target list
defconfigs: Piggyback microblazeel on microblaze
microblaze: mmu: Delete flip_um fn prototype
microblaze: cpu: Remote unused cpu_get_pc
microblaze: cpu: Remove unused CC_OP enum
microblaze: cpu: Delete EXCP_NMI
microblaze: cpu: delete unused cpu_interrupts_enabled
tcg: Delete unused cpu_pc_from_tb()
Stefan Berger (3):
tpm: Cast 64bit variables to int when used in DPRINTF
tpm: Modify DPRINTF to enable -Wformat checking
tpm: fix coding style
Stefan Weil (1):
misc: Fix new collection of typos
Thomas Huth (6):
vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags()
pci: Remove unused function ich9_d2pbr_init()
monitor: Remove unused functions
usb: Remove unused functions
util: Remove unused functions
kvm: Silence warning from valgrind
backends/hostmem-file.c | 2 +-
configure | 4 +-
cpus.c | 2 +-
default-configs/microblazeel-softmmu.mak | 10 +----
dma-helpers.c | 1 -
docs/atomics.txt | 4 +-
hmp.h | 1 -
hw/acpi/pcihp.c | 1 -
hw/block/virtio-blk.c | 2 +-
hw/display/qxl.c | 2 +-
hw/i386/acpi-build.c | 1 -
hw/microblaze/boot.c | 13 ++++---
hw/mips/mips_fulong2e.c | 1 +
hw/mips/mips_malta.c | 1 +
hw/mips/mips_r4k.c | 1 +
hw/misc/edu.c | 2 +-
hw/net/virtio-net.c | 2 +-
hw/net/vmxnet_rx_pkt.c | 7 ----
hw/net/vmxnet_rx_pkt.h | 9 -----
hw/pci-bridge/i82801b11.c | 21 ----------
hw/ppc/spapr.c | 2 +-
hw/tpm/tpm_passthrough.c | 16 ++++----
hw/tpm/tpm_tis.c | 26 ++++++-------
hw/usb/core.c | 41 --------------------
hw/virtio/vhost-user.c | 22 +++++------
include/hw/i386/ich9.h | 2 -
include/hw/pci-host/q35.h | 1 -
include/hw/usb.h | 5 ---
include/monitor/monitor.h | 1 -
include/qemu-common.h | 4 --
include/qemu/bitops.h | 61 ++++++++++++++---------------
include/qemu/compatfd.h | 1 -
kvm-all.c | 14 +++----
libcacard/cac.c | 5 ++-
libcacard/card_7816.c | 4 +-
libcacard/event.c | 2 +-
libcacard/vcard.c | 4 +-
libcacard/vcard_emul_nss.c | 4 +-
libcacard/vcardt.c | 4 +-
libcacard/vreader.c | 4 +-
libcacard/vscclient.c | 8 +++-
linux-user/elfload.c | 3 +-
monitor.c | 13 -------
qemu-char.c | 1 -
qemu-coroutine-lock.c | 2 +-
qemu-options.hx | 2 +-
qga/qapi-schema.json | 2 +-
qmp-commands.hx | 4 +-
target-arm/cpu.h | 14 -------
target-microblaze/cpu.h | 27 +++----------
target-microblaze/mmu.h | 1 -
target-s390x/mmu_helper.c | 8 ++--
target-s390x/translate.c | 2 +-
target-tricore/cpu.h | 5 ---
tcg/tcg.h | 6 ++-
tests/i440fx-test.c | 2 -
tests/libqos/ahci.c | 4 +-
ui/console.c | 4 +-
ui/input-legacy.c | 2 -
ui/spice-display.c | 8 ++--
ui/vnc-auth-vencrypt.c | 8 ++--
ui/vnc-tls.c | 10 ++---
ui/vnc-ws.c | 4 +-
ui/vnc.c | 2 +-
util/compatfd.c | 19 ---------
util/osdep.c | 66 --------------------------------
util/qemu-config.c | 2 -
67 files changed, 156 insertions(+), 383 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30
2015-04-30 5:08 Michael Tokarev
@ 2015-04-30 12:58 ` Peter Maydell
2015-04-30 13:05 ` Michael Tokarev
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2015-04-30 12:58 UTC (permalink / raw)
To: Michael Tokarev; +Cc: QEMU Trivial, QEMU Developers
On 30 April 2015 at 06:08, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Hello.
>
> This is the first pull request for trivial-patches tree since 2.3 has
> been released. During the freeze many patches has been accumulated,
> and even more has been received after 2.4 developmnent has been opened.
>
> So here we have 42 trivial patches, which is kinda too much, but that's
> what we have :)
>
> Please consider applying.
>
> Thanks,
>
> /mjt
>
> The following changes since commit a9392bc93c8615ad1983047e9f91ee3fa8aae75f:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-04-28 16:55:03 +0100)
>
> are available in the git repository at:
>
> git://git.corpit.ru/qemu.git tags/pull-trivial-patches-2015-04-30
>
> for you to fetch changes up to fe31d3e6e6945b509e5b4ab03d38aae1266fe64e:
>
> microblaze: fix memory leak (2015-04-30 08:06:20 +0300)
>
> ----------------------------------------------------------------
> trivial patches for 2015-04-30
Hi. I'm afraid this fails to build the tests on OSX:
CC tests/i440fx-test.o
/Users/pm215/src/qemu/tests/i440fx-test.c:229:21: warning: implicit declaration
of function 'ARRAY_SIZE' is invalid in C99
[-Wimplicit-function-declaration]
for (i = 0; i < ARRAY_SIZE(pam_area); i++) {
^
1 warning generated.
LINK tests/i440fx-test
Undefined symbols for architecture x86_64:
"_ARRAY_SIZE", referenced from:
_test_i440fx_pam in i440fx-test.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [tests/i440fx-test] Error 1
'i440fx-test: remove ARRAY_SIZE redefinition' has removed
this macro, but this test file doesn't include osdep.h so
it presumably works on Linux only because we're picking
something up from a system header file somewhere...
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30
2015-04-30 12:58 ` Peter Maydell
@ 2015-04-30 13:05 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-04-30 13:05 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Trivial, QEMU Developers
30.04.2015 15:58, Peter Maydell wrote:
[]
> Hi. I'm afraid this fails to build the tests on OSX:
> CC tests/i440fx-test.o
> /Users/pm215/src/qemu/tests/i440fx-test.c:229:21: warning: implicit declaration
> of function 'ARRAY_SIZE' is invalid in C99
So much for trivial ;)
Let's remove this one and add another tiny dead code removal patch
instead, which went in meanwhile, to complete half-removal of unused
functions. I'll resend another pull request in a moment.
Thanks, and sorry for the noize. I wanted to verify if this array_size
definition is really unnecessary here but something distracted me.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-30 17:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-30 13:10 [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Michael Tokarev
2015-04-30 13:10 ` [Qemu-devel] [PULL 42/42] openrisc: cpu: Remove unused cpu_get_pc Michael Tokarev
2015-04-30 17:03 ` [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30 Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2015-04-30 5:08 Michael Tokarev
2015-04-30 12:58 ` Peter Maydell
2015-04-30 13:05 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).