qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	afaerber@suse.de, edgar.iglesias@gmail.com
Subject: [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders
Date: Tue, 23 Jun 2015 20:19:19 -0700	[thread overview]
Message-ID: <cover.1435115710.git.crosthwaite.peter@gmail.com> (raw)

Wrap the CPUClass::set_pc fn hook in a caller helper to reduce
verbosity of calls. Simplify the call from the gdbstub.

Then use the call to abstract away the PC env fields from the ARM and
Microblaze bootloaders.

This moves towards the goal of minimising system level code of the CPU
env (and one step closer to common-obj'ing the bootloaders). There's a
long way to go (at least for ARM, not so far for MB), but this is a
small win in that direction.

This helps with multi-arch where the current thinking is to compile
out the maximum content possible from cpu.h. This removes program
counter definitions from the multi-arch cpu.h compile-in list.

changed since v2:
drop error argument
misc commit messages tweaks

changed since v1:
Remove thumb changes

Peter Crosthwaite (4):
  cpu: Add wrapper to the set-pc() hook
  gdbstub: Use cpu_set_pc() helper
  arm: boot: Use cpu_set_pc()
  microblaze: boot: Use cpu_set_pc()

 dtc                  |  2 +-
 gdbstub.c            |  5 +----
 hw/arm/boot.c        | 19 +++++++------------
 hw/microblaze/boot.c |  2 +-
 include/qom/cpu.h    | 17 +++++++++++++++++
 5 files changed, 27 insertions(+), 18 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-06-24  3:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  3:19 Peter Crosthwaite [this message]
2015-06-24  3:19 ` [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook Peter Crosthwaite
2015-06-24 18:09   ` Andreas Färber
2015-06-24 19:11     ` Peter Maydell
2015-06-25 11:12       ` Andreas Färber
2015-06-25 11:21         ` Peter Maydell
2015-06-25 16:21           ` Andreas Färber
2015-06-24  3:19 ` [Qemu-devel] [PATCH qom v3 2/4] gdbstub: Use cpu_set_pc() helper Peter Crosthwaite
2015-06-24  3:19 ` [Qemu-devel] [PATCH qom v3 3/4] arm: boot: Use cpu_set_pc() Peter Crosthwaite
2015-06-24 18:22   ` Andreas Färber
2015-06-24 18:26     ` Peter Crosthwaite
2015-06-24 19:13     ` Peter Maydell
2015-06-24  3:19 ` [Qemu-devel] [PATCH qom v3 4/4] microblaze: " Peter Crosthwaite
2015-06-24 18:00   ` Andreas Färber
2015-06-24 18:29     ` Andreas Färber
2015-06-25  2:08       ` Peter Crosthwaite
2015-06-24 18:36 ` [Qemu-devel] [PATCH qom v3 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1435115710.git.crosthwaite.peter@gmail.com \
    --to=crosthwaitepeter@gmail.com \
    --cc=afaerber@suse.de \
    --cc=crosthwaite.peter@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).