From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWLul-000692-JP for qemu-devel@nongnu.org; Mon, 31 Aug 2015 06:02:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWLuh-0004i0-IT for qemu-devel@nongnu.org; Mon, 31 Aug 2015 06:02:11 -0400 From: Alberto Garcia Date: Mon, 31 Aug 2015 13:00:23 +0300 Message-Id: Subject: [Qemu-devel] [PATCH 0/1] Allow passing BlockdevOptions to blockdev-snapshot-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alberto Garcia , Stefan Hajnoczi , qemu-block@nongnu.org, Max Reitz Here's my first attempt to solve the problem explained here: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02847.html In short: there's no way to pass options to snapshots created using blockdev-snapshot-sync. This patch simply allows passing a BlockdevOptions structure to that command. I'm not 100% happy with the API because there's some overlap with a couple of parameters, but it's the simplest I could think of. This need to be applied on top of this series from Max Reitz: https://lists.gnu.org/archive/html/qemu-block/2015-08/msg00189.html Regards, Berto Alberto Garcia (1): block: Allow passing BlockdevOptions to blockdev-snapshot-sync blockdev.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++------ hmp.c | 2 +- qapi/block-core.json | 9 +++++++- qmp-commands.hx | 3 ++- 4 files changed, 64 insertions(+), 9 deletions(-) -- 2.5.0