qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, jsnow@redhat.com,
	armbru@redhat.com, programmingkidx@gmail.com
Subject: [Qemu-devel] [PATCH v2 0/2] Auto-generated IDs
Date: Tue,  1 Sep 2015 18:30:14 -0400	[thread overview]
Message-ID: <cover.1441140367.git.jcody@redhat.com> (raw)

Changes from RFC v1:

    Patch 1: Several typos / grammatical errors (thanks Eric, John)
             Make id_subsys_str[] const pointer to const strings (thanks Eric)
             Moved id_subsys_str[] out from  id_generate() (thanks John)
             Assert on null string for given id (thanks Eric)
             Zero-pad the 2-digit random # (thanks John)

    Patch 2: None

Born from the conversation on qemu-devel, this generation scheme uses the
format ultimately proposed by Kevin, after list discussion.

It attempts to keep the ID strings as small as possible, while fulfilling:
    
    1.) Guarantee no collisions with a user-specified ID
    2.) Identify the sub-system the ID belongs to
    3.) Guarantee of uniqueness
    4.) Spoiling predictibility, to avoid creating an assumption
        of object ordering and parsing (i.e., we don't want users to think
        they can guess the next ID based on prior behavior).

See patch 1 for the generation scheme details.

Jeff Cody (2):
  util - add automated ID generation utility
  block: auto-generated node-names

 block.c               | 25 ++++++++++++++++---------
 include/qemu-common.h |  8 ++++++++
 util/id.c             | 36 ++++++++++++++++++++++++++++++++++++
 3 files changed, 60 insertions(+), 9 deletions(-)

-- 
1.9.3

             reply	other threads:[~2015-09-01 22:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 22:30 Jeff Cody [this message]
2015-09-01 22:30 ` [Qemu-devel] [PATCH v2 1/2] util - add automated ID generation utility Jeff Cody
2015-09-01 22:55   ` Eric Blake
2015-09-02  0:08     ` Jeff Cody
2015-09-02  0:13   ` John Snow
2015-09-02  6:35   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-09-03 14:47     ` Jeff Cody
2015-09-18 12:58   ` [Qemu-devel] " Markus Armbruster
2015-09-01 22:30 ` [Qemu-devel] [PATCH v2 2/2] block: auto-generated node-names Jeff Cody
2015-09-18 13:03   ` Markus Armbruster
2015-09-03 15:02 ` [Qemu-devel] [PATCH v2 0/2] Auto-generated IDs Kevin Wolf
2015-09-03 15:54   ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2015-09-18 13:06 ` [Qemu-devel] " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1441140367.git.jcody@redhat.com \
    --to=jcody@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).