From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmLue-0004SA-CJ for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:16:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmLud-0004Rk-BR for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:16:12 -0400 From: Jeff Cody Date: Wed, 14 Oct 2015 09:15:59 -0400 Message-Id: Subject: [Qemu-devel] [PATCH 0/3] Prefer bdrv_lookup_bs() to find BDS nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, armbru@redhat.com, qemu-block@nongnu.org, quintela@redhat.com This series is on top of Alberto's "Add 'blockdev-snapshot' command" series BlockBackend devices and BlockDriverState node-names occupy the same namespace. In addition, there are two methods that can be used in different circumstances to look up a BlockDriverState: blk_by_name() and bdrv_find_node(). There is also a common interface, bdrv_lookup_bs(), that can look up either by blk_by_name() or bdrv_find_node(). This makes bdrv_find_node() redundant for an external interface. And in the cases where we just want the underlying BDS for a BlockBackend device, it is simpler to use bdrv_lookup_bs() instead of blk_by_name(). This series makes bdrv_find_node() static and internal to block.c as a helper function, and attempts to simplify some code when we are looking just for the BDS of a BlockBackend device. Jeff Cody (3): block: Use bdrv_lookup_bs() instead of bdrv_find_node() block: make bdrv_find_node() static block: use bdrv_lookup_bs() over blk_by_name() for BDS only results block.c | 30 +++++++++--------- block/block-backend.c | 2 +- block/mirror.c | 2 +- block/write-threshold.c | 2 +- blockdev.c | 84 ++++++++++++++++++------------------------------- include/block/block.h | 1 - migration/block.c | 6 ++-- 7 files changed, 50 insertions(+), 77 deletions(-) -- 1.9.3