From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrR1Y-000880-CC for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:44:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrR1W-0005Tu-3w for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:44:20 -0400 From: Alberto Garcia Date: Wed, 28 Oct 2015 15:43:48 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, qemu-stable@nongnu.org, Max Reitz , Stefan Hajnoczi This series fixes a bug in the 'block-commit' operation under the following scenario: [A] <- [B] <- [C] <- [D] If we do block-commit top=B base=A, the contents of [B] will be written into [A] resulting in this chain: [A] <- [C] <- [D] In order to perform this operation, [A] must be reopened in read-write mode but so does [C] because its backing file string needs to be updated to point at [A]. There's a bug in the current code that makes [A] read-only again when [C] is reopened. This series includes a fix for that bug plus a test case for the scenario. This affects both master and the 2.4 branch. Berto Alberto Garcia (2): commit: reopen overlay_bs before base qemu-iotests: Test the reopening of overlay_bs in 'block-commit' block/commit.c | 8 ++++---- tests/qemu-iotests/040 | 30 ++++++++++++++++++++++++++++++ tests/qemu-iotests/040.out | 4 ++-- 3 files changed, 36 insertions(+), 6 deletions(-) -- 2.6.1