From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtE22-0001Ce-Tf for qemu-devel@nongnu.org; Mon, 02 Nov 2015 07:16:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtE20-0004MY-1J for qemu-devel@nongnu.org; Mon, 02 Nov 2015 07:16:14 -0500 From: Alberto Garcia Date: Mon, 2 Nov 2015 14:15:03 +0200 Message-Id: Subject: [Qemu-devel] [PATCH v2 0/2] Disallow snapshots if the overlay doesn't support backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz We are currently allowing snapshots in cases like this one: { 'execute': 'blockdev-add', 'arguments': { 'options': { 'driver': 'qcow2', 'node-name': 'new0', 'file': { 'driver': 'file', 'filename': 'new.qcow2', 'node-name': 'file0' } } } } { 'execute': 'blockdev-snapshot', 'arguments': { 'node': 'virtio0', 'overlay': 'file0' } } This patch forbids snapshots if the overlay node does not support backing files. Regards, Berto v2: - Disallow snapshots if new_bs->drv->supports_backing is false [Max] v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06875.html - Initial version. Alberto Garcia (2): block: Disallow snapshots if the overlay doesn't support backing files block: test 'blockdev-snapshot' using a file BDS as the overlay blockdev.c | 5 +++++ tests/qemu-iotests/085 | 12 +++++++++++- tests/qemu-iotests/085.out | 4 ++++ 3 files changed, 20 insertions(+), 1 deletion(-) -- 2.6.1