From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtYte-0003tA-Cv for qemu-devel@nongnu.org; Tue, 03 Nov 2015 05:32:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtYtb-0004KR-3X for qemu-devel@nongnu.org; Tue, 03 Nov 2015 05:32:58 -0500 From: Alberto Garcia Date: Tue, 3 Nov 2015 12:32:34 +0200 Message-Id: Subject: [Qemu-devel] [PATCH v3 0/3] Disallow snapshots if the overlay doesn't support backing files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz We are currently allowing snapshots in cases like this one: { 'execute': 'blockdev-add', 'arguments': { 'options': { 'driver': 'qcow2', 'node-name': 'new0', 'file': { 'driver': 'file', 'filename': 'new.qcow2', 'node-name': 'file0' } } } } { 'execute': 'blockdev-snapshot', 'arguments': { 'node': 'virtio0', 'overlay': 'file0' } } This patch forbids snapshots if the overlay node does not support backing files. Regards, Berto v3: - patch 2: new patch to remove all the existing inner quotation marks in test 085 [Max, Eric] - patch 3: fix description and remove inner quotation marks [Max, Eric] v2: https://lists.gnu.org/archive/html/qemu-block/2015-11/msg00005.html - Disallow snapshots if new_bs->drv->supports_backing is false [Max] v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06875.html - Initial version. Alberto Garcia (3): block: Disallow snapshots if the overlay doesn't support backing files block: Remove inner quotation marks in iotest 085 block: test 'blockdev-snapshot' using a file BDS as the overlay blockdev.c | 5 +++++ tests/qemu-iotests/085 | 26 ++++++++++++++++++-------- tests/qemu-iotests/085.out | 4 ++++ 3 files changed, 27 insertions(+), 8 deletions(-) -- 2.6.2