From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 0/4] Separate QUORUM_REPORT_BAD events according to their node name
Date: Wed, 9 Mar 2016 18:11:17 +0200 [thread overview]
Message-ID: <cover.1457539274.git.berto@igalia.com> (raw)
Hi,
this was proposed by Eric in a recent email, but I'll summarize it
here:
QUORUM_REPORT_BAD events are limited to a maximum rate of 1 per
second. While this is not a problem in itself, this means that an
error in one a Quorum child will mask errors in the other children if
they happen within the same 1 second interval.
This series fixes that problem by separating these events in different
queues if they come from different nodes. Once we add the 'type' field
to QUORUM_REPORT_BAD we will also be able to classify them according
to the type if we want.
In addition to the above, this series also fixes a crash that happens
if there's an I/O error in one of the children. This is serious enough
so I'll send the patch to fix this crash to qemu-stable as well.
Regards,
Beto
Alberto Garcia (4):
quorum: Fix crash in quorum_aio_cb()
monitor: Separate QUORUM_REPORT_BAD events according to the node name
monitor: Use QEMU_CLOCK_VIRTUAL for the event queue in qtest mode
iotests: Add test for QMP event rates
block/quorum.c | 12 +++--
monitor.c | 22 ++++++--
tests/qemu-iotests/146 | 129 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/146.out | 5 ++
tests/qemu-iotests/group | 1 +
5 files changed, 161 insertions(+), 8 deletions(-)
create mode 100644 tests/qemu-iotests/146
create mode 100644 tests/qemu-iotests/146.out
--
2.7.0
next reply other threads:[~2016-03-09 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 16:11 Alberto Garcia [this message]
2016-03-09 16:11 ` [Qemu-devel] [PATCH 1/4] quorum: Fix crash in quorum_aio_cb() Alberto Garcia
2016-03-09 16:54 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-03-10 10:10 ` Alberto Garcia
2016-03-11 12:35 ` Max Reitz
2016-03-09 16:11 ` [Qemu-devel] [PATCH 2/4] monitor: Separate QUORUM_REPORT_BAD events according to the node name Alberto Garcia
2016-03-09 17:03 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-03-09 16:11 ` [Qemu-devel] [PATCH 3/4] monitor: Use QEMU_CLOCK_VIRTUAL for the event queue in qtest mode Alberto Garcia
2016-03-09 17:06 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-03-09 16:11 ` [Qemu-devel] [PATCH 4/4] iotests: Add test for QMP event rates Alberto Garcia
2016-03-09 17:36 ` [Qemu-devel] [Qemu-block] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1457539274.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).