From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adgiD-000760-9A for qemu-devel@nongnu.org; Wed, 09 Mar 2016 11:11:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adgi9-0006KZ-FL for qemu-devel@nongnu.org; Wed, 09 Mar 2016 11:11:49 -0500 From: Alberto Garcia Date: Wed, 9 Mar 2016 18:11:17 +0200 Message-Id: Subject: [Qemu-devel] [PATCH 0/4] Separate QUORUM_REPORT_BAD events according to their node name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alberto Garcia , qemu-block@nongnu.org Hi, this was proposed by Eric in a recent email, but I'll summarize it here: QUORUM_REPORT_BAD events are limited to a maximum rate of 1 per second. While this is not a problem in itself, this means that an error in one a Quorum child will mask errors in the other children if they happen within the same 1 second interval. This series fixes that problem by separating these events in different queues if they come from different nodes. Once we add the 'type' field to QUORUM_REPORT_BAD we will also be able to classify them according to the type if we want. In addition to the above, this series also fixes a crash that happens if there's an I/O error in one of the children. This is serious enough so I'll send the patch to fix this crash to qemu-stable as well. Regards, Beto Alberto Garcia (4): quorum: Fix crash in quorum_aio_cb() monitor: Separate QUORUM_REPORT_BAD events according to the node name monitor: Use QEMU_CLOCK_VIRTUAL for the event queue in qtest mode iotests: Add test for QMP event rates block/quorum.c | 12 +++-- monitor.c | 22 ++++++-- tests/qemu-iotests/146 | 129 +++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/146.out | 5 ++ tests/qemu-iotests/group | 1 + 5 files changed, 161 insertions(+), 8 deletions(-) create mode 100644 tests/qemu-iotests/146 create mode 100644 tests/qemu-iotests/146.out -- 2.7.0