From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, qemu-stable@nongnu.org,
Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Alberto Garcia <berto@igalia.com>
Subject: [Qemu-devel] [PATCH 0/2] Correct access to wrong BlockBackendPublic structures
Date: Mon, 17 Oct 2016 18:46:01 +0300 [thread overview]
Message-ID: <cover.1476718804.git.berto@igalia.com> (raw)
Hi all,
Paolo found that commit 27ccdd52598290f introduced a regression in the
throttling code.
It can be easily reproduced in scenarios where you have a throttling
group with several drives but you only write to one of them. In that
case the round-robin algorithm can select the wrong drive all the time
and the actual requests are never completed.
QEMU 2.7 is affected, here's the patch to fix it, plus a test case.
Thanks,
Berto
Alberto Garcia (2):
throttle: Correct access to wrong BlockBackendPublic structures
qemu-iotests: Test I/O in a single drive from a throttling group
block/throttle-groups.c | 27 +++++++++++++++++++++++----
tests/qemu-iotests/093 | 33 ++++++++++++++++++++++++++++-----
tests/qemu-iotests/093.out | 4 ++--
3 files changed, 53 insertions(+), 11 deletions(-)
--
2.9.3
next reply other threads:[~2016-10-17 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 15:46 Alberto Garcia [this message]
2016-10-17 15:46 ` [Qemu-devel] [PATCH 1/2] throttle: Correct access to wrong BlockBackendPublic structures Alberto Garcia
2016-10-17 15:56 ` Paolo Bonzini
2016-10-17 15:46 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Test I/O in a single drive from a throttling group Alberto Garcia
2016-10-18 14:09 ` [Qemu-devel] [PATCH 0/2] Correct access to wrong BlockBackendPublic structures Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1476718804.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).