From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwA7O-0006Wh-9o for qemu-devel@nongnu.org; Mon, 17 Oct 2016 11:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwA7J-0001vR-Dc for qemu-devel@nongnu.org; Mon, 17 Oct 2016 11:46:26 -0400 From: Alberto Garcia Date: Mon, 17 Oct 2016 18:46:01 +0300 Message-Id: Subject: [Qemu-devel] [PATCH 0/2] Correct access to wrong BlockBackendPublic structures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, qemu-stable@nongnu.org, Kevin Wolf , Paolo Bonzini , Alberto Garcia Hi all, Paolo found that commit 27ccdd52598290f introduced a regression in the throttling code. It can be easily reproduced in scenarios where you have a throttling group with several drives but you only write to one of them. In that case the round-robin algorithm can select the wrong drive all the time and the actual requests are never completed. QEMU 2.7 is affected, here's the patch to fix it, plus a test case. Thanks, Berto Alberto Garcia (2): throttle: Correct access to wrong BlockBackendPublic structures qemu-iotests: Test I/O in a single drive from a throttling group block/throttle-groups.c | 27 +++++++++++++++++++++++---- tests/qemu-iotests/093 | 33 ++++++++++++++++++++++++++++----- tests/qemu-iotests/093.out | 4 ++-- 3 files changed, 53 insertions(+), 11 deletions(-) -- 2.9.3