qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, armbru@redhat.com, berrange@redhat.com,
	eblake@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] RBD: blockdev-add
Date: Mon, 27 Feb 2017 02:30:37 -0500	[thread overview]
Message-ID: <cover.1488180142.git.jcody@redhat.com> (raw)


This series adds blockdev-add for rbd.

However, there is an area that will likely need to change.  In the RBD
driver, all options for Ceph are supported, but the qemu driver is not
explicitly aware of all the options.

There are a few options that the QEMU driver cares about and handles, while
the other options are merely split out until their string key/value pairs
and passed along to Ceph.  In patches 3 and 4, this patch series does
the same practice, and parses all the extra options as a long string.

For QAPI, this is not acceptable - so I presume the best way to handle it
is with an array schema of structs.  I'll reply to the specific patches in
the problem areas, and see what the preference is from an API perspective
 to handle this.




Jeff Cody (4):
  block/rbd: don't copy strings in qemu_rbd_next_tok()
  block/rbd: code movement
  block/rbd: parse all options via bdrv_parse_filename
  block/rbd: Add blockdev-add support

 block/rbd.c          | 435 +++++++++++++++++++++++++++++----------------------
 qapi/block-core.json |  47 +++++-
 2 files changed, 289 insertions(+), 193 deletions(-)

-- 
2.9.3

             reply	other threads:[~2017-02-27  7:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27  7:30 Jeff Cody [this message]
2017-02-27  7:30 ` [Qemu-devel] [PATCH 1/4] block/rbd: don't copy strings in qemu_rbd_next_tok() Jeff Cody
2017-02-27 16:39   ` Markus Armbruster
2017-02-27 18:07     ` Jeff Cody
2017-02-27  7:30 ` [Qemu-devel] [PATCH 2/4] block/rbd: code movement Jeff Cody
2017-02-27  9:28   ` Daniel P. Berrange
2017-02-27 13:14     ` Jeff Cody
2017-02-27  7:30 ` [Qemu-devel] [PATCH 3/4] block/rbd: parse all options via bdrv_parse_filename Jeff Cody
2017-02-27  7:30 ` [Qemu-devel] [PATCH 4/4] block/rbd: Add blockdev-add support Jeff Cody
2017-02-27  7:36   ` Jeff Cody
2017-02-27  9:31     ` Daniel P. Berrange
2017-02-27 13:18       ` Jeff Cody
2017-02-27 13:30         ` Daniel P. Berrange
2017-02-27 13:38           ` Jeff Cody
2017-02-27 13:45   ` Daniel P. Berrange
2017-02-27 15:27     ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1488180142.git.jcody@redhat.com \
    --to=jcody@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).