[Qemu-devel] [PATCH 0/2] Minor VXHS fixups

[Qemu-devel] [PATCH 0/2] Minor VXHS fixups

[Jeff Cody]

This fixes a couple of small issues with VXHS; modularization, and improved
error messaging.

Jeff Cody (2):
  block/vxhs: Allow VXHS to be built as a module
  block/vxhs: set errp on iio_init() failure

 block/vxhs.c | 1 +
 configure    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.9.3

[Qemu-devel] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module

[Jeff Cody]

In 88d8879, protocol drivers had modularization enabled.  As VXHS is a
protocol, make sure it is able to be built as a module as well.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 48a9370..eada141 100755
--- a/configure
+++ b/configure
@@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
 fi
 
 if test "$vxhs" = "yes" ; then
-  echo "CONFIG_VXHS=y" >> $config_host_mak
+  echo "CONFIG_VXHS=m" >> $config_host_mak
   echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
 fi
 
-- 
2.9.3

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module

[John Snow]

On 05/04/2017 05:35 PM, Jeff Cody wrote:
> In 88d8879, protocol drivers had modularization enabled.  As VXHS is a
> protocol, make sure it is able to be built as a module as well.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 48a9370..eada141 100755
> --- a/configure
> +++ b/configure
> @@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
>  fi
>  
>  if test "$vxhs" = "yes" ; then
> -  echo "CONFIG_VXHS=y" >> $config_host_mak
> +  echo "CONFIG_VXHS=m" >> $config_host_mak
>    echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
>  fi
>  
> 

ERROR: User requested feature vxhs block device
       configure was not able to find it.
       Install libvxhs See github

wow gee, thanks configure file. I'll go "see github."

Not actually that easy to find; separate patch, but could this be
touched up?

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block/vxhs: Allow VXHS to be built as a module

[Jeff Cody]

On Mon, May 08, 2017 at 01:29:46PM -0400, John Snow wrote:
> 
> 
> On 05/04/2017 05:35 PM, Jeff Cody wrote:
> > In 88d8879, protocol drivers had modularization enabled.  As VXHS is a
> > protocol, make sure it is able to be built as a module as well.
> > 
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index 48a9370..eada141 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then
> >  fi
> >  
> >  if test "$vxhs" = "yes" ; then
> > -  echo "CONFIG_VXHS=y" >> $config_host_mak
> > +  echo "CONFIG_VXHS=m" >> $config_host_mak
> >    echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak
> >  fi
> >  
> > 
> 
> ERROR: User requested feature vxhs block device
>        configure was not able to find it.
>        Install libvxhs See github
> 
> wow gee, thanks configure file. I'll go "see github."
> 
> Not actually that easy to find; separate patch, but could this be
> touched up?

Sure, that is an easy touch up.  I'll add it as a v2 to this patch.

[Qemu-devel] [PATCH 2/2] block/vxhs: set errp on iio_init() failure

[Jeff Cody]

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/vxhs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/vxhs.c b/block/vxhs.c
index 9ffe9d3..1f1e5db 100644
--- a/block/vxhs.c
+++ b/block/vxhs.c
@@ -301,6 +301,7 @@ static int vxhs_open(BlockDriverState *bs, QDict *options,
 
     ret = vxhs_init_and_ref();
     if (ret < 0) {
+        error_setg(&local_err, "libvxhs iio_init() failed");
         ret = -EINVAL;
         goto out;
     }
-- 
2.9.3