From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dD14n-0005Aj-7N for qemu-devel@nongnu.org; Tue, 23 May 2017 00:05:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dD14m-0004hN-2P for qemu-devel@nongnu.org; Tue, 23 May 2017 00:05:41 -0400 Received: from [59.151.112.132] (port=40966 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dD14l-0004gt-M2 for qemu-devel@nongnu.org; Tue, 23 May 2017 00:05:39 -0400 From: Mao Zhongyi Date: Tue, 23 May 2017 12:04:36 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, jasowang@redhat.com, f4bug@amsat.org, jiri@resnulli.us v5: * Patch 1 removed the dead error handling that was previously missing. * Patch 2 and 3 has not changed. * Patch 4 is a new patch to fix the unusual macro name. v4: * Patch 1 is following Markus's suggestion that remove the dead error handling. * Patch 2 is separate from patch 1 to plug the memory leak in the v3. * Patch 3 is based on the patch 1 in the v3. Meanwhile, dorp the superfluous prefix "rocker:" and adjust the commit message. v3: * Following Jason's suggstion that add suitable error message to each error site. * Modified the commit message to make it easier to read. v2: * Following Philippe's suggestion that shorten the patch subject "hw/net/rocker/rocker" to "net/rocker". * Use a consistent log format to report error message. * Add a specific goto label "err_name_too_long" to make a correct cleanup. Mao Zhongyi (4): net/rocker: Remove the dead error handling net/rocker: Plug memory leak in pci_rocker_init() net/rocker: Convert to realize() net/rocker: Fix the unusual macro name hw/net/rocker/rocker.c | 93 ++++++++++--------------------------------- hw/net/rocker/rocker_desc.c | 10 ----- hw/net/rocker/rocker_fp.c | 4 -- hw/net/rocker/rocker_of_dpa.c | 20 ---------- hw/net/rocker/rocker_world.c | 12 +++--- 5 files changed, 27 insertions(+), 112 deletions(-) -- 2.9.3