qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org, armbru@redhat.com
Cc: alistair.francis@xilinx.com, alistair23@gmail.com
Subject: [Qemu-devel] [RFC v1 0/3]  Implement a warning_report function
Date: Tue, 27 Jun 2017 13:45:41 -0700	[thread overview]
Message-ID: <cover.1498596157.git.alistair.francis@xilinx.com> (raw)

QEMU currently has a standard method to report errors with
error_repot(). This ensure a sane and standard format when printing
errors. This series is attempting to add the same functionality for
warnings.

At the moment only one error is being converted, I wanted to get the
implementation nailed down a little bit before I started converting
others.

This patch renames error_print_loc() function to be more clear, but I
didn't bother renaming the others. It seems silly to change
error_printf() to error_warning_printf() and printf is already taken so
I just left it as is.

I also didn't change the current error output as that would probably
break backwards compatibilty for anyone who is parsing logs.

Alistair Francis (3):
  util/qemu-error: Rename error_print_loc() to be more generic
  util/qemu-error: Add a warning_report() function
  char-socket: Report TCP socket waiting as a warning

 chardev/char-socket.c       |  2 +-
 include/qemu/error-report.h |  2 ++
 util/qemu-error.c           | 36 ++++++++++++++++++++++++++++++++++--
 3 files changed, 37 insertions(+), 3 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-06-27 20:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 20:45 Alistair Francis [this message]
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 1/3] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-06-28  4:32   ` Philippe Mathieu-Daudé
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() function Alistair Francis
2017-06-27 22:21   ` Thomas Huth
2017-06-28  0:16     ` Alistair Francis
2017-06-28  9:04   ` Daniel P. Berrange
2017-06-28 16:16     ` Alistair Francis
2017-06-28 16:19       ` Daniel P. Berrange
2017-06-29  7:38         ` Markus Armbruster
2017-06-27 20:45 ` [Qemu-devel] [RFC v1 3/3] char-socket: Report TCP socket waiting as a warning Alistair Francis
2017-06-27 21:10   ` Edgar E. Iglesias
2017-06-28  0:17     ` Alistair Francis
2017-06-28  6:15       ` Edgar E. Iglesias
2017-06-28 16:18         ` Alistair Francis
2017-06-28  9:07 ` [Qemu-devel] [RFC v1 0/3] Implement a warning_report function Daniel P. Berrange
2017-06-28 15:49   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1498596157.git.alistair.francis@xilinx.com \
    --to=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).