From: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com, armbru@redhat.com, berrange@redhat.com,
kraxel@redhat.com, pbonzini@redhat.com, eblake@redhat.com
Subject: [Qemu-devel] [PATCH v7 0/4] Improve error reporting
Date: Thu, 29 Jun 2017 17:42:58 +0800 [thread overview]
Message-ID: <cover.1498727785.git.maozy.fnst@cn.fujitsu.com> (raw)
v7:
* PATCH 01
-fix the error message. [Daniel P. Berrange]
-adjust the Indentation problem. [Eric Blake]
* PATCH 03
-print a generic message when gethostbyname() failed in parse_host_port(),
drop the misleading ": unkonwn host" part. [Markus Armbruster]
v6:
* PATCH 02
-rename the subject
-drop the "qemu: error: " prefix.
-correct inappropriate error information settings.
* PATCH 03,04
-correct inappropriate error information settings. [Markus Armbruster]
v5:
* PATCH 01 make the commit message more exact about the actual function. [Markus Armbruster]
* PATCH 02, 03, 04 still retains the original function, but specific
content and order of each patch has been adjusted substantially,
so that ensure each patch is a completed fix. [Markus Armbruster]
v4:
* PATCH 01 is redoing previous patch 1, replace the fprintf() with error_report()
in the 'default' case of net_socket_fd_init() [Markus Armbruster]
v3:
* PATCH 01 is suggested by Markus and Daniel that removes the dubious 'default' case
in the net_socket_fd_init(). Jason agreed.
* PATCH 02 is redoing previous patch 4.
* PATCH 04 is redoing previous patch 2, improves sort of error messages.
v2:
* PATCH 02 reworking of patch 2 following Markus's suggestion that convert error_report()
in the function called by net_socket_*_init() to Error. Also add many error
handling information.
* PATCH 03 net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init()
use the function such as fprintf, perror to report an error message. Convert it
to Error.
* PATCH 04 parse_host_port() may fail without reporting an error. Now, fix it to set an
error when it fails.
Cc: jasowang@redhat.com
Cc: armbru@redhat.com
Cc: berrange@redhat.com
Cc: kraxel@redhat.com
Cc: pbonzini@redhat.com
Cc: eblake@redhat.com
Mao Zhongyi (4):
net/socket: Don't treat odd socket type as SOCK_STREAM
net/socket: Convert several helper functions to Error
net/net: Convert parse_host_port() to Error
net/socket: Improve -net socket error reporting
include/qemu/sockets.h | 3 +-
net/net.c | 22 +++++--
net/socket.c | 156 ++++++++++++++++++++++++++++---------------------
3 files changed, 109 insertions(+), 72 deletions(-)
--
2.9.4
next reply other threads:[~2017-06-29 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:42 Mao Zhongyi [this message]
2017-06-29 9:42 ` [Qemu-devel] [PATCH v7 1/4] net/socket: Don't treat odd socket type as SOCK_STREAM Mao Zhongyi
2017-06-29 9:43 ` [Qemu-devel] [PATCH v7 2/4] net/socket: Convert several helper functions to Error Mao Zhongyi
2017-07-04 14:54 ` Markus Armbruster
2017-07-05 3:20 ` Mao Zhongyi
2017-06-29 9:43 ` [Qemu-devel] [PATCH v7 3/4] net/net: Convert parse_host_port() " Mao Zhongyi
2017-07-04 14:58 ` Markus Armbruster
2017-06-29 9:43 ` [Qemu-devel] [PATCH v7 4/4] net/socket: Improve -net socket error reporting Mao Zhongyi
2017-07-04 16:24 ` Markus Armbruster
2017-07-05 3:30 ` Mao Zhongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1498727785.git.maozy.fnst@cn.fujitsu.com \
--to=maozy.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).