From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQVz9-0001zT-Ed for qemu-devel@nongnu.org; Thu, 29 Jun 2017 05:43:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQVz7-0003jg-DK for qemu-devel@nongnu.org; Thu, 29 Jun 2017 05:43:39 -0400 Received: from [59.151.112.132] (port=35910 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQVz7-0003ce-0y for qemu-devel@nongnu.org; Thu, 29 Jun 2017 05:43:37 -0400 From: Mao Zhongyi Date: Thu, 29 Jun 2017 17:42:58 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v7 0/4] Improve error reporting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jasowang@redhat.com, armbru@redhat.com, berrange@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, eblake@redhat.com v7: * PATCH 01 -fix the error message. [Daniel P. Berrange] -adjust the Indentation problem. [Eric Blake] * PATCH 03 -print a generic message when gethostbyname() failed in parse_host_port(), drop the misleading ": unkonwn host" part. [Markus Armbruster] v6: * PATCH 02 -rename the subject -drop the "qemu: error: " prefix. -correct inappropriate error information settings. * PATCH 03,04 -correct inappropriate error information settings. [Markus Armbruster] v5: * PATCH 01 make the commit message more exact about the actual function. [Markus Armbruster] * PATCH 02, 03, 04 still retains the original function, but specific content and order of each patch has been adjusted substantially, so that ensure each patch is a completed fix. [Markus Armbruster] v4: * PATCH 01 is redoing previous patch 1, replace the fprintf() with error_report() in the 'default' case of net_socket_fd_init() [Markus Armbruster] v3: * PATCH 01 is suggested by Markus and Daniel that removes the dubious 'default' case in the net_socket_fd_init(). Jason agreed. * PATCH 02 is redoing previous patch 4. * PATCH 04 is redoing previous patch 2, improves sort of error messages. v2: * PATCH 02 reworking of patch 2 following Markus's suggestion that convert error_report() in the function called by net_socket_*_init() to Error. Also add many error handling information. * PATCH 03 net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf, perror to report an error message. Convert it to Error. * PATCH 04 parse_host_port() may fail without reporting an error. Now, fix it to set an error when it fails. Cc: jasowang@redhat.com Cc: armbru@redhat.com Cc: berrange@redhat.com Cc: kraxel@redhat.com Cc: pbonzini@redhat.com Cc: eblake@redhat.com Mao Zhongyi (4): net/socket: Don't treat odd socket type as SOCK_STREAM net/socket: Convert several helper functions to Error net/net: Convert parse_host_port() to Error net/socket: Improve -net socket error reporting include/qemu/sockets.h | 3 +- net/net.c | 22 +++++-- net/socket.c | 156 ++++++++++++++++++++++++++++--------------------- 3 files changed, 109 insertions(+), 72 deletions(-) -- 2.9.4